linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>,
	Daejun Park <daejun7.park@samsung.com>,
	Kanchan Joshi <joshi.k@samsung.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Douglas Gilbert <dgilbert@interlog.com>
Subject: [PATCH v5 12/17] scsi_debug: Support the block limits extension VPD page
Date: Wed, 29 Nov 2023 17:33:17 -0800	[thread overview]
Message-ID: <20231130013322.175290-13-bvanassche@acm.org> (raw)
In-Reply-To: <20231130013322.175290-1-bvanassche@acm.org>

From SBC-5 r05:

"Reduced stream control:
a) reduces the maximum number of streams that the device server supports;
   and
b) increases the number of write commands that are able to specify a stream
   to be written in any write command that contains the GROUP NUMBER field
   in its CDB.

If the RSCS bit (see 6.6.5) is set to one, then the device server shall:
a) support per group stream identifier usage as described in 4.32.2;
b) support the IO Advice Hints Grouping mode page (see 6.5.7); and
c) set the MAXIMUM NUMBER OF STREAMS field (see 6.6.5) to a value that is
   less than 64.

Device servers that set the RSCS bit to one may support other features
(e.g., permanent streams (see 4.32.4)).

4.32.4 Permanent streams

A permanent stream is a stream for which the device server does not allow
closing or otherwise modifying the configuration of that stream. The PERM
bit (see 5.9.2.3) indicates whether a stream is a permanent stream. If a
STREAM CONTROL command (see 5.32) specifies the closing of a permanent
stream, the device server terminates that command with CHECK CONDITION
status instead of closing the specified stream. A permanent stream is always
an open stream. Device severs should assign the lowest numbered stream
identifiers to permanent streams."

Report that reduced stream control is supported.

Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/scsi/scsi_debug.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index f6261ad76c09..b9a39829a012 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -1931,6 +1931,7 @@ static int resp_inquiry(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
 					arr[n++] = 0xb2;  /* LB Provisioning */
 				if (is_zbc)
 					arr[n++] = 0xb6;  /* ZB dev. char. */
+				arr[n++] = 0xb7;  /* Block limits extension */
 			}
 			arr[3] = n - 4;	  /* number of supported VPD pages */
 		} else if (0x80 == cmd[2]) { /* unit serial number */
@@ -1973,6 +1974,9 @@ static int resp_inquiry(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
 			arr[3] = inquiry_vpd_b2(&arr[4]);
 		} else if (is_zbc && cmd[2] == 0xb6) { /* ZB dev. charact. */
 			arr[3] = inquiry_vpd_b6(devip, &arr[4]);
+		} else if (cmd[2] == 0xb7) { /* block limits extension page */
+			arr[3] = 2; /* page length */
+			arr[5] = 1; /* Reduced stream control support (RSCS) */
 		} else {
 			mk_sense_invalid_fld(scp, SDEB_IN_CDB, 2, -1);
 			kfree(arr);

  parent reply	other threads:[~2023-11-30  1:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30  1:33 [PATCH v5 00/17] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 01/17] fs: Fix rw_hint validation Bart Van Assche
2023-12-07 17:42   ` Christoph Hellwig
2023-11-30  1:33 ` [PATCH v5 02/17] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-07 17:44   ` Christoph Hellwig
2023-11-30  1:33 ` [PATCH v5 03/17] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-07 17:45   ` Christoph Hellwig
2023-12-07 19:39     ` Bart Van Assche
2023-12-11 16:44       ` Christoph Hellwig
2023-11-30  1:33 ` [PATCH v5 04/17] fs: Restore F_[GS]ET_FILE_RW_HINT support Bart Van Assche
2023-12-07 17:46   ` Christoph Hellwig
2023-12-07 19:37     ` Bart Van Assche
2023-12-11 16:45       ` Christoph Hellwig
2023-11-30  1:33 ` [PATCH v5 05/17] fs: Restore kiocb.ki_hint Bart Van Assche
2023-12-07 17:46   ` Christoph Hellwig
2023-12-07 23:40     ` Bart Van Assche
2023-12-11 16:46       ` Christoph Hellwig
2023-11-30  1:33 ` [PATCH v5 06/17] block: Restore the per-bio/request data lifetime fields Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 07/17] block: Propagate write hints to the block device inode Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 08/17] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-11-30 12:21   ` Johannes Thumshirn
2023-11-30  1:33 ` [PATCH v5 09/17] scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-11-30 13:19   ` Johannes Thumshirn
2023-12-01  1:46     ` Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 10/17] sd: Translate data lifetime information Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 11/17] scsi_debug: Reduce code duplication Bart Van Assche
2023-11-30  1:33 ` Bart Van Assche [this message]
2023-11-30  1:33 ` [PATCH v5 13/17] scsi_debug: Rework page code error handling Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 14/17] scsi_debug: Rework subpage " Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 15/17] scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 16/17] scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-11-30  1:33 ` [PATCH v5 17/17] scsi_debug: Maintain write statistics per group number Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231130013322.175290-13-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=daejun7.park@samsung.com \
    --cc=dgilbert@interlog.com \
    --cc=hch@lst.de \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).