From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Daejun Park <daejun7.park@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Bart Van Assche <bvanassche@acm.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v5 07/17] block: Propagate write hints to the block device inode
Date: Wed, 29 Nov 2023 17:33:12 -0800 [thread overview]
Message-ID: <20231130013322.175290-8-bvanassche@acm.org> (raw)
In-Reply-To: <20231130013322.175290-1-bvanassche@acm.org>
Write hints applied with F_SET_RW_HINT on a block device affect the
shmem inode only. Propagate these hints to the block device inode
because that is the inode used when writing back dirty pages.
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/fops.c | 11 +++++++++++
fs/fcntl.c | 4 ++++
include/linux/fs.h | 1 +
3 files changed, 16 insertions(+)
diff --git a/block/fops.c b/block/fops.c
index 2de61d81f8ec..87ddaf3ac831 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -620,6 +620,16 @@ static int blkdev_release(struct inode *inode, struct file *filp)
return 0;
}
+static void blkdev_apply_whint(struct file *file, enum rw_hint hint)
+{
+ struct bdev_handle *handle = file->private_data;
+ struct inode *bd_inode = handle->bdev->bd_inode;
+
+ inode_lock(bd_inode);
+ bd_inode->i_write_hint = hint;
+ inode_unlock(bd_inode);
+}
+
static ssize_t
blkdev_direct_write(struct kiocb *iocb, struct iov_iter *from)
{
@@ -854,6 +864,7 @@ const struct file_operations def_blk_fops = {
.splice_read = filemap_splice_read,
.splice_write = iter_file_splice_write,
.fallocate = blkdev_fallocate,
+ .apply_whint = blkdev_apply_whint,
};
static __init int blkdev_init(void)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index fe80e19f1c1a..c0f8b7e880a4 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -287,6 +287,7 @@ static bool rw_hint_valid(u64 hint)
static long fcntl_rw_hint(struct file *file, unsigned int cmd,
unsigned long arg)
{
+ void (*apply_whint)(struct file *, enum rw_hint);
struct inode *inode = file_inode(file);
u64 __user *argp = (u64 __user *)arg;
u64 hint;
@@ -320,6 +321,9 @@ static long fcntl_rw_hint(struct file *file, unsigned int cmd,
inode_lock(inode);
inode->i_write_hint = hint;
+ apply_whint = inode->i_fop->apply_whint;
+ if (apply_whint)
+ apply_whint(file, hint);
inode_unlock(inode);
return 0;
default:
diff --git a/include/linux/fs.h b/include/linux/fs.h
index acc0cbab93dd..c5f82b88a82e 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1946,6 +1946,7 @@ struct file_operations {
int (*uring_cmd)(struct io_uring_cmd *ioucmd, unsigned int issue_flags);
int (*uring_cmd_iopoll)(struct io_uring_cmd *, struct io_comp_batch *,
unsigned int poll_flags);
+ void (*apply_whint)(struct file *, enum rw_hint hint);
} __randomize_layout;
/* Wrap a directory iterator that needs exclusive inode access */
next prev parent reply other threads:[~2023-11-30 1:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 1:33 [PATCH v5 00/17] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 01/17] fs: Fix rw_hint validation Bart Van Assche
2023-12-07 17:42 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 02/17] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-07 17:44 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 03/17] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-07 17:45 ` Christoph Hellwig
2023-12-07 19:39 ` Bart Van Assche
2023-12-11 16:44 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 04/17] fs: Restore F_[GS]ET_FILE_RW_HINT support Bart Van Assche
2023-12-07 17:46 ` Christoph Hellwig
2023-12-07 19:37 ` Bart Van Assche
2023-12-11 16:45 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 05/17] fs: Restore kiocb.ki_hint Bart Van Assche
2023-12-07 17:46 ` Christoph Hellwig
2023-12-07 23:40 ` Bart Van Assche
2023-12-11 16:46 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 06/17] block: Restore the per-bio/request data lifetime fields Bart Van Assche
2023-11-30 1:33 ` Bart Van Assche [this message]
2023-11-30 1:33 ` [PATCH v5 08/17] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-11-30 12:21 ` Johannes Thumshirn
2023-11-30 1:33 ` [PATCH v5 09/17] scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-11-30 13:19 ` Johannes Thumshirn
2023-12-01 1:46 ` Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 10/17] sd: Translate data lifetime information Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 11/17] scsi_debug: Reduce code duplication Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 12/17] scsi_debug: Support the block limits extension VPD page Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 13/17] scsi_debug: Rework page code error handling Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 14/17] scsi_debug: Rework subpage " Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 15/17] scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 16/17] scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 17/17] scsi_debug: Maintain write statistics per group number Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130013322.175290-8-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=daejun7.park@samsung.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).