From: Christian Brauner <brauner@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.com>,
Jens Axboe <axboe@kernel.dk>, Carlos Llamas <cmllamas@google.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH RFC 3/5] fs: replace f_rcuhead with f_tw
Date: Fri, 1 Dec 2023 14:19:59 +0100 [thread overview]
Message-ID: <20231201-archaisch-blatt-771818b94798@brauner> (raw)
In-Reply-To: <CAHk-=wjWvbbX4c-8nGWOqMden6X8k=8kYCNfy96r0N+8FJbU6g@mail.gmail.com>
On Fri, Dec 01, 2023 at 08:37:30AM +0900, Linus Torvalds wrote:
> On Thu, 30 Nov 2023 at 21:49, Christian Brauner <brauner@kernel.org> wrote:
> >
> > The naming is actively misleading since we switched to
> > SLAB_TYPESAFE_BY_RCU. rcu_head is #define callback_head. Use
> > callback_head directly and rename f_rcuhead to f_tw.
>
> Please just write it out, ie "f_taskwork" or something. Using random
> letter combinations is very illegible. It may make sense at the time
> (when you are literally editing a line about "init_task_work()") but
> it's literally just line noise in that structure definition that makes
> me go "f_tw is wtf backwards, wtf?".
Oh, I didn't even think about this.
> It might even be a good idea to say *what* it is a task work for.
Ok, I've added a comment about for both f_llist and f_task_work.
next prev parent reply other threads:[~2023-12-01 13:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 12:49 [PATCH RFC 0/5] file: minor fixes Christian Brauner
2023-11-30 12:49 ` [PATCH RFC 1/5] file: s/close_fd_get_file()/file_close_fd()/g Christian Brauner
2023-11-30 16:39 ` Jan Kara
2023-11-30 12:49 ` [PATCH RFC 2/5] file: remove pointless wrapper Christian Brauner
2023-11-30 14:22 ` Jens Axboe
2023-11-30 16:40 ` Jan Kara
2023-11-30 12:49 ` [PATCH RFC 3/5] fs: replace f_rcuhead with f_tw Christian Brauner
2023-11-30 16:42 ` Jan Kara
2023-11-30 23:37 ` Linus Torvalds
2023-12-01 13:19 ` Christian Brauner [this message]
2023-11-30 12:49 ` [PATCH RFC 4/5] file: stop exposing receive_fd_user() Christian Brauner
2023-11-30 14:23 ` Jens Axboe
2023-11-30 16:43 ` Jan Kara
2023-11-30 12:49 ` [PATCH RFC 5/5] file: remove __receive_fd() Christian Brauner
2023-11-30 13:20 ` Matthew Wilcox
2023-12-01 13:12 ` Christian Brauner
2023-11-30 16:44 ` Jan Kara
2023-11-30 14:23 ` [PATCH RFC 0/5] file: minor fixes Jens Axboe
2023-12-01 13:23 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201-archaisch-blatt-771818b94798@brauner \
--to=brauner@kernel.org \
--cc=axboe@kernel.dk \
--cc=cmllamas@google.com \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox