From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Support fanotify FAN_REPORT_FID on all filesystems
Date: Fri, 1 Dec 2023 10:56:35 +0100 [thread overview]
Message-ID: <20231201095635.e2ydmmdd22lntmrf@quack3> (raw)
In-Reply-To: <20231130165619.3386452-1-amir73il@gmail.com>
Hi!
On Thu 30-11-23 18:56:17, Amir Goldstein wrote:
> Jan,
>
> In the vfs fanotify update for v6.7-rc1 [1], we considerably increased
> the amount of filesystems that can setup inode marks with FAN_REPORT_FID:
> - NFS export is no longer required for setting up inode marks
> - All the simple fs gained a non-zero fsid
>
> This leaves the following in-tree filesystems where inode marks with
> FAN_REPORT_FID cannot be set:
> - nfs, fuse, afs, coda (zero fsid)
> - btrfs non-root subvol (fsid not a unique identifier of sb)
>
> This patch set takes care of these remaining cases, by allowing inode
> marks, as long as all inode marks in the group are contained to the same
> filesystem and same fsid (i.e. subvol).
>
> I've written some basic sanity tests [2] and a man-page update draft [3].
> The LTP tests excersize the new code by running tests that did not run
> before on ntfs-3g fuse filesystem and skipping the test cases with mount
> and sb marks.
>
> I've also tested fsnotifywait --recursive on fuse and on btrfs subvol.
> It works as expected - if tree travesal crosses filesystem or subvol
> boundary, setting the subdir mark fails with -EXDEV.
Now all the patches have arrived. Queued into my tree.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-12-01 9:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 16:56 [PATCH v2 0/2] Support fanotify FAN_REPORT_FID on all filesystems Amir Goldstein
2023-11-30 16:56 ` [PATCH v2 1/2] fanotify: store fsid in mark instead of in connector Amir Goldstein
2023-11-30 16:56 ` [PATCH v2 2/2] fanotify: allow "weak" fsid when watching a single filesystem Amir Goldstein
2023-11-30 17:12 ` Jan Kara
2023-11-30 17:18 ` Amir Goldstein
2023-11-30 17:23 ` Amir Goldstein
2023-12-01 9:56 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201095635.e2ydmmdd22lntmrf@quack3 \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).