From: Joel Granados <j.granados@samsung.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>, <willy@infradead.org>,
<josh@joshtriplett.org>, Kees Cook <keescook@chromium.org>,
Eric Biederman <ebiederm@xmission.com>,
Iurii Zaikin <yzaikin@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Balbir Singh <bsingharora@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, <linux-kernel@vger.kernel.org>,
<kexec@lists.infradead.org>, <linux-fsdevel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH 07/10] printk: Remove the now superfluous sentinel elements from ctl_table array
Date: Mon, 4 Dec 2023 09:56:28 +0100 [thread overview]
Message-ID: <20231204085628.pf7yxppacf4pm2cv@localhost> (raw)
In-Reply-To: <ZWX0L4lV8TWOgcpv@alley>
[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]
Hey Petr
I missed this message somehow....
On Tue, Nov 28, 2023 at 03:07:43PM +0100, Petr Mladek wrote:
> On Tue 2023-11-07 14:45:07, Joel Granados via B4 Relay wrote:
> > From: Joel Granados <j.granados@samsung.com>
> >
> > This commit comes at the tail end of a greater effort to remove the
> > empty elements at the end of the ctl_table arrays (sentinels) which
> > will reduce the overall build time size of the kernel and run time
> > memory bloat by ~64 bytes per sentinel (further information Link :
> > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> >
> > rm sentinel element from printk_sysctls
> >
> > Signed-off-by: Joel Granados <j.granados@samsung.com>
>
> I am a bit sceptical if the size and time reduction is worth the
> effort. I feel that this change makes the access a bit less secure.
In what way "less secure"? Can you expand on that?
Notice that if you pass a pointer to the register functions, you will
get a warning/error on compilation.
>
> Well, almost all arrays are static so that it should just work.
> The patch does what it says. Feel free to use:
Thx for the review. will do.
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> Best Regards,
> Petr
--
Joel Granados
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-12-04 8:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 13:45 [PATCH 00/10] sysctl: Remove sentinel elements from kernel dir Joel Granados via B4 Relay
2023-11-07 13:45 ` [PATCH 01/10] kernel misc: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2023-11-07 13:45 ` [PATCH 02/10] umh: " Joel Granados via B4 Relay
2023-11-07 13:45 ` [PATCH 03/10] ftrace: " Joel Granados via B4 Relay
2023-11-08 10:29 ` Masami Hiramatsu
2023-11-08 16:27 ` Steven Rostedt
2023-11-07 13:45 ` [PATCH 04/10] timekeeping: " Joel Granados via B4 Relay
2023-11-07 13:45 ` [PATCH 05/10] seccomp: " Joel Granados via B4 Relay
2023-11-07 19:55 ` Kees Cook
2023-11-07 13:45 ` [PATCH 06/10] scheduler: " Joel Granados via B4 Relay
2023-11-07 14:49 ` Peter Zijlstra
2023-11-07 13:45 ` [PATCH 07/10] printk: " Joel Granados via B4 Relay
2023-11-28 14:07 ` Petr Mladek
2023-12-04 8:56 ` Joel Granados [this message]
2023-12-06 9:55 ` Petr Mladek
2023-11-07 13:45 ` [PATCH 08/10] kprobes: " Joel Granados via B4 Relay
2023-11-08 10:27 ` Masami Hiramatsu
2023-11-07 13:45 ` [PATCH 09/10] delayacct: " Joel Granados via B4 Relay
2023-11-07 13:45 ` [PATCH 10/10] bpf: " Joel Granados via B4 Relay
2023-11-07 18:15 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204085628.pf7yxppacf4pm2cv@localhost \
--to=j.granados@samsung.com \
--cc=andrii@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=bsingharora@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dietmar.eggemann@arm.com \
--cc=ebiederm@xmission.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=jolsa@kernel.org \
--cc=josh@joshtriplett.org \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=kpsingh@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=sdf@google.com \
--cc=senozhatsky@chromium.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wad@chromium.org \
--cc=willy@infradead.org \
--cc=yonghong.song@linux.dev \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).