From: Amir Goldstein <amir73il@gmail.com>
To: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: Jeff Layton <jlayton@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Christoph Hellwig <hch@lst.de>,
David Howells <dhowells@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Miklos Szeredi <miklos@szeredi.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/4] Prepare for fsnotify pre-content permission events
Date: Thu, 7 Dec 2023 14:38:21 +0200 [thread overview]
Message-ID: <20231207123825.4011620-1-amir73il@gmail.com> (raw)
Hi Jan & Christian,
I am not planning to post the fanotify pre-content event patches [1]
for 6.8. Not because they are not ready, but because the usersapce
example is not ready.
Also, I think it is a good idea to let the large permission hooks
cleanup work to mature over the 6.8 cycle, before we introduce the
pre-content events.
However, I would like to include the following vfs prep patches along
with the vfs.rw PR for 6.8, which could be titled as the subject of
this cover letter.
Patch 1 is a variant of a cleanup suggested by Christoph to get rid
of the generic_copy_file_range() exported symbol.
Patches 2,3 add the file_write_not_started() assertion to fsnotify
file permission hooks. IMO, it is important to merge it along with
vfs.rw because:
1. This assert is how I tested vfs.rw does what it aimed to achieve
2. This will protect us from new callers that break the new order
3. The commit message of patch 3 provides the context for the entire
series and can be included in the PR message
Patch 4 is the final change of fsnotify permission hook locations/args
and is the last of the vfs prerequsites for pre-content events.
If we merge patch 4 for 6.8, it will be much easier for the development
of fanotify pre-content events in 6.9 dev cycle, which be contained
within the fsnotify subsystem.
Thanks,
Amir.
[1] https://github.com/amir73il/linux/commits/fan_pre_content
Amir Goldstein (4):
fs: use splice_copy_file_range() inline helper
fsnotify: split fsnotify_perm() into two hooks
fsnotify: assert that file_start_write() is not held in permission
hooks
fsnotify: pass access range in file permission hooks
fs/ceph/file.c | 4 ++--
fs/fuse/file.c | 5 +++--
fs/nfs/nfs4file.c | 5 +++--
fs/open.c | 4 ++++
fs/read_write.c | 44 ++++++++--------------------------------
fs/readdir.c | 4 ++++
fs/remap_range.c | 8 +++++++-
fs/smb/client/cifsfs.c | 5 +++--
fs/splice.c | 2 +-
include/linux/fs.h | 3 ---
include/linux/fsnotify.h | 42 ++++++++++++++++++++++++--------------
include/linux/splice.h | 8 ++++++++
security/security.c | 10 ++-------
13 files changed, 72 insertions(+), 72 deletions(-)
--
2.34.1
next reply other threads:[~2023-12-07 12:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 12:38 Amir Goldstein [this message]
2023-12-07 12:38 ` [PATCH 1/4] fs: use splice_copy_file_range() inline helper Amir Goldstein
2023-12-08 17:33 ` Christian Brauner
2023-12-10 10:07 ` Amir Goldstein
2023-12-08 18:27 ` Jan Kara
2023-12-07 12:38 ` [PATCH 2/4] fsnotify: split fsnotify_perm() into two hooks Amir Goldstein
2023-12-08 18:33 ` Jan Kara
2023-12-07 12:38 ` [PATCH 3/4] fsnotify: assert that file_start_write() is not held in permission hooks Amir Goldstein
2023-12-08 18:46 ` Jan Kara
2023-12-08 21:02 ` Amir Goldstein
2023-12-11 10:30 ` Jan Kara
2023-12-11 10:57 ` Amir Goldstein
2023-12-07 12:38 ` [PATCH 4/4] fsnotify: pass access range in file " Amir Goldstein
2023-12-08 17:52 ` Christian Brauner
2023-12-08 18:53 ` Jan Kara
2023-12-08 21:34 ` Amir Goldstein
2023-12-10 13:24 ` Amir Goldstein
2023-12-11 11:49 ` Jan Kara
2023-12-11 12:00 ` Amir Goldstein
2023-12-11 14:53 ` Jan Kara
2023-12-07 21:51 ` [PATCH 0/4] Prepare for fsnotify pre-content permission events Josef Bacik
2023-12-08 7:34 ` Amir Goldstein
2023-12-15 17:00 ` Amir Goldstein
2023-12-15 20:04 ` Josef Bacik
2023-12-08 17:54 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207123825.4011620-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).