From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Daejun Park <daejun7.park@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v5 01/17] fs: Fix rw_hint validation
Date: Thu, 7 Dec 2023 18:42:42 +0100 [thread overview]
Message-ID: <20231207174242.GA31184@lst.de> (raw)
In-Reply-To: <20231130013322.175290-2-bvanassche@acm.org>
On Wed, Nov 29, 2023 at 05:33:06PM -0800, Bart Van Assche wrote:
> Reject values that are valid rw_hints after truncation but not before
> truncation by passing an untruncated value to rw_hint_valid().
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, having one helper for F_GET_RW_HINT and F_SET_RW_HINT looks
pretty odd to me, it seems like the code would be cleaner if that
was split into two helpers instead.
next prev parent reply other threads:[~2023-12-07 17:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 1:33 [PATCH v5 00/17] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 01/17] fs: Fix rw_hint validation Bart Van Assche
2023-12-07 17:42 ` Christoph Hellwig [this message]
2023-11-30 1:33 ` [PATCH v5 02/17] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-07 17:44 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 03/17] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-07 17:45 ` Christoph Hellwig
2023-12-07 19:39 ` Bart Van Assche
2023-12-11 16:44 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 04/17] fs: Restore F_[GS]ET_FILE_RW_HINT support Bart Van Assche
2023-12-07 17:46 ` Christoph Hellwig
2023-12-07 19:37 ` Bart Van Assche
2023-12-11 16:45 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 05/17] fs: Restore kiocb.ki_hint Bart Van Assche
2023-12-07 17:46 ` Christoph Hellwig
2023-12-07 23:40 ` Bart Van Assche
2023-12-11 16:46 ` Christoph Hellwig
2023-11-30 1:33 ` [PATCH v5 06/17] block: Restore the per-bio/request data lifetime fields Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 07/17] block: Propagate write hints to the block device inode Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 08/17] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-11-30 12:21 ` Johannes Thumshirn
2023-11-30 1:33 ` [PATCH v5 09/17] scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-11-30 13:19 ` Johannes Thumshirn
2023-12-01 1:46 ` Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 10/17] sd: Translate data lifetime information Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 11/17] scsi_debug: Reduce code duplication Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 12/17] scsi_debug: Support the block limits extension VPD page Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 13/17] scsi_debug: Rework page code error handling Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 14/17] scsi_debug: Rework subpage " Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 15/17] scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 16/17] scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-11-30 1:33 ` [PATCH v5 17/17] scsi_debug: Maintain write statistics per group number Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207174242.GA31184@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chuck.lever@oracle.com \
--cc=daejun7.park@samsung.com \
--cc=jlayton@kernel.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).