Re: [PATCH v3 1/5] splice: return type ssize_t from all helpers

[Christian Brauner <brauner@kernel.org>]

On Tue, Dec 12, 2023 at 03:19:37PM +0100, Jan Kara wrote:
> On Tue 12-12-23 11:44:36, Amir Goldstein wrote:
> > Not sure why some splice helpers return long, maybe historic reasons.
> > Change them all to return ssize_t to conform to the splice methods and
> > to the rest of the helpers.
> > 
> > Suggested-by: Christian Brauner <brauner@kernel.org>
> > Link: https://lore.kernel.org/r/20231208-horchen-helium-d3ec1535ede5@brauner/
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> 
> Looks good to me. Just one nit below. Feel free to add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> 
> > diff --git a/fs/splice.c b/fs/splice.c
> > index 7cda013e5a1e..13030ce192d9 100644
> > --- a/fs/splice.c
> > +++ b/fs/splice.c
> > @@ -201,7 +201,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
> >  	unsigned int tail = pipe->tail;
> >  	unsigned int head = pipe->head;
> >  	unsigned int mask = pipe->ring_size - 1;
> > -	int ret = 0, page_nr = 0;
> > +	ssize_t ret = 0, page_nr = 0;
> 
> A nit but page_nr should stay to be 'int'.

Fixed in-tree.