From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Christoph Hellwig <hch@lst.de>,
David Howells <dhowells@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Miklos Szeredi <miklos@szeredi.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] splice: return type ssize_t from all helpers
Date: Tue, 12 Dec 2023 15:19:37 +0100 [thread overview]
Message-ID: <20231212141937.f4ihbex46ndhu3nt@quack3> (raw)
In-Reply-To: <20231212094440.250945-2-amir73il@gmail.com>
On Tue 12-12-23 11:44:36, Amir Goldstein wrote:
> Not sure why some splice helpers return long, maybe historic reasons.
> Change them all to return ssize_t to conform to the splice methods and
> to the rest of the helpers.
>
> Suggested-by: Christian Brauner <brauner@kernel.org>
> Link: https://lore.kernel.org/r/20231208-horchen-helium-d3ec1535ede5@brauner/
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Looks good to me. Just one nit below. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
> diff --git a/fs/splice.c b/fs/splice.c
> index 7cda013e5a1e..13030ce192d9 100644
> --- a/fs/splice.c
> +++ b/fs/splice.c
> @@ -201,7 +201,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
> unsigned int tail = pipe->tail;
> unsigned int head = pipe->head;
> unsigned int mask = pipe->ring_size - 1;
> - int ret = 0, page_nr = 0;
> + ssize_t ret = 0, page_nr = 0;
A nit but page_nr should stay to be 'int'.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-12-12 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 9:44 [PATCH v3 0/5] Prepare for fsnotify pre-content permission events Amir Goldstein
2023-12-12 9:44 ` [PATCH v3 1/5] splice: return type ssize_t from all helpers Amir Goldstein
2023-12-12 14:19 ` Jan Kara [this message]
2023-12-12 15:20 ` Christian Brauner
2023-12-12 9:44 ` [PATCH v3 2/5] fs: use splice_copy_file_range() inline helper Amir Goldstein
2023-12-12 9:44 ` [PATCH v3 3/5] fsnotify: split fsnotify_perm() into two hooks Amir Goldstein
2023-12-12 9:44 ` [PATCH v3 4/5] fsnotify: assert that file_start_write() is not held in permission hooks Amir Goldstein
2023-12-12 9:44 ` [PATCH v3 5/5] fsnotify: optionally pass access range in file " Amir Goldstein
2023-12-12 13:34 ` [PATCH v3 0/5] Prepare for fsnotify pre-content permission events Christian Brauner
2023-12-12 15:22 ` [PATCH v3 1/5] splice: return type ssize_t from all helpers David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212141937.f4ihbex46ndhu3nt@quack3 \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).