From: Al Viro <viro@zeniv.linux.org.uk>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: Re: [viro-vfs:headers.unaligned 2/2] drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory
Date: Thu, 14 Dec 2023 09:14:18 +0000 [thread overview]
Message-ID: <20231214091418.GP1674809@ZenIV> (raw)
In-Reply-To: <202312141458.agmsUCZB-lkp@intel.com>
On Thu, Dec 14, 2023 at 02:50:07PM +0800, kernel test robot wrote:
> Hi Al,
>
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git headers.unaligned
> head: 959598f725aa7721a4bad53c2e997c7255ff32dc
> commit: 959598f725aa7721a4bad53c2e997c7255ff32dc [2/2] move asm/unaligned.h to linux/unaligned.h
> config: i386-buildonly-randconfig-002-20231214 (https://download.01.org/0day-ci/archive/20231214/202312141458.agmsUCZB-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312141458.agmsUCZB-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312141458.agmsUCZB-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from drivers/cxl/core/pci.c:13:
> >> drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory
> 11 | #include <asm-generic/unaligned.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
Charming... Anything of that sort deserves to be hunted
down and shot - including gems like this:
net/sunrpc/xprtrdma/verbs.c:58:#include <asm-generic/barrier.h>
OK, I'll adjust the script, but IMO we should make it a matter of policy -
*NOTHING* outside of arch/ and include/ should ever have
#include <asm-generic/whatever.h>
#include <asm/something.h> is generally best avoided, but it is
defendable; asm-generic is not.
prev parent reply other threads:[~2023-12-14 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 6:50 [viro-vfs:headers.unaligned 2/2] drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory kernel test robot
2023-12-14 9:14 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214091418.GP1674809@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).