[viro-vfs:headers.unaligned 2/2] drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory

[viro-vfs:headers.unaligned 2/2] drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory

[kernel test robot]

Hi Al,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git headers.unaligned
head:   959598f725aa7721a4bad53c2e997c7255ff32dc
commit: 959598f725aa7721a4bad53c2e997c7255ff32dc [2/2] move asm/unaligned.h to linux/unaligned.h
config: i386-buildonly-randconfig-002-20231214 (https://download.01.org/0day-ci/archive/20231214/202312141458.agmsUCZB-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312141458.agmsUCZB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312141458.agmsUCZB-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/cxl/core/pci.c:13:
>> drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory
      11 | #include <asm-generic/unaligned.h>
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~
   compilation terminated.


vim +11 drivers/cxl/core/trace.h

2f6e9c305127f8 include/trace/events/cxl.h Dave Jiang       2022-11-29   8  
2f6e9c305127f8 include/trace/events/cxl.h Dave Jiang       2022-11-29   9  #include <linux/tracepoint.h>
ddf49d57b841e5 drivers/cxl/core/trace.h   Alison Schofield 2023-04-18  10  #include <linux/pci.h>
6ebe28f9ec7228 drivers/cxl/core/trace.h   Ira Weiny        2023-01-17 @11  #include <asm-generic/unaligned.h>
6ebe28f9ec7228 drivers/cxl/core/trace.h   Ira Weiny        2023-01-17  12  

:::::: The code at line 11 was first introduced by commit
:::::: 6ebe28f9ec7228e1a35df6074695ac11d7cdcf68 cxl/mem: Read, trace, and clear events on driver load

:::::: TO: Ira Weiny <ira.weiny@intel.com>
:::::: CC: Dan Williams <dan.j.williams@intel.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [viro-vfs:headers.unaligned 2/2] drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory

[Al Viro]

On Thu, Dec 14, 2023 at 02:50:07PM +0800, kernel test robot wrote:
> Hi Al,
> 
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git headers.unaligned
> head:   959598f725aa7721a4bad53c2e997c7255ff32dc
> commit: 959598f725aa7721a4bad53c2e997c7255ff32dc [2/2] move asm/unaligned.h to linux/unaligned.h
> config: i386-buildonly-randconfig-002-20231214 (https://download.01.org/0day-ci/archive/20231214/202312141458.agmsUCZB-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312141458.agmsUCZB-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312141458.agmsUCZB-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from drivers/cxl/core/pci.c:13:
> >> drivers/cxl/core/trace.h:11:10: fatal error: asm-generic/unaligned.h: No such file or directory
>       11 | #include <asm-generic/unaligned.h>
>          |          ^~~~~~~~~~~~~~~~~~~~~~~~~

Charming...   Anything of that sort deserves to be hunted
down and shot - including gems like this:

net/sunrpc/xprtrdma/verbs.c:58:#include <asm-generic/barrier.h>

OK, I'll adjust the script, but IMO we should make it a matter of policy -
*NOTHING* outside of arch/ and include/ should ever have
#include <asm-generic/whatever.h>

#include <asm/something.h> is generally best avoided, but it is
defendable; asm-generic is not.