linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-mm@kvack.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jan Kara <jack@suse.com>, David Howells <dhowells@redhat.com>
Subject: Convert write_cache_pages() to an iterator v2
Date: Thu, 14 Dec 2023 14:25:33 +0100	[thread overview]
Message-ID: <20231214132544.376574-1-hch@lst.de> (raw)

Hi all,

this is basically a report of willy's series of the same name for June.
I picked the lastest version from his (now apparently defunct) git tree,
rebased it to mainline (no coflict, neither for linux-next), reordered
the new fields in struct writeback_control to document what is interface
vs internal, and temporarily dropped the iomap patch due to a conflict
in the VFS tree.

willy: let me know if me reposting it like this is fine, or if you
want me to stop.  I'd just really like to see it merged :)
Note that patch 4 is missing your signoff, so we'd need that before
proceeding anyway.

The original cover letter is below:

Dave Howells doesn't like the indirect function call imposed by
write_cache_pages(), so refactor it into an iterator.  I took the
opportunity to add the ability to iterate a folio_batch without having
an external variable.

This is against next-20230623.  If you try to apply it on top of a tree
which doesn't include the pagevec removal series, IT WILL CRASH because
it won't reinitialise folio_batch->i and the iteration will index out
of bounds.

I have a feeling the 'done' parameter could have a better name, but I
can't think what it might be.

Diffstat:
 include/linux/pagevec.h   |   18 ++
 include/linux/writeback.h |   24 +++
 mm/page-writeback.c       |  313 +++++++++++++++++++++++++---------------------
 3 files changed, 211 insertions(+), 144 deletions(-)

             reply	other threads:[~2023-12-14 13:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 13:25 Christoph Hellwig [this message]
2023-12-14 13:25 ` [PATCH 01/11] writeback: Factor out writeback_finish() Christoph Hellwig
2023-12-15 13:26   ` Jan Kara
2023-12-15 16:54     ` Christoph Hellwig
2023-12-14 13:25 ` [PATCH 02/11] writeback: Factor writeback_get_batch() out of write_cache_pages() Christoph Hellwig
2023-12-15 14:14   ` Jan Kara
2023-12-14 13:25 ` [PATCH 03/11] writeback: Factor should_writeback_folio() " Christoph Hellwig
2023-12-15 14:16   ` Jan Kara
2023-12-14 13:25 ` [PATCH 04/11] writeback: Simplify the loops in write_cache_pages() Christoph Hellwig
2023-12-15 14:25   ` Jan Kara
2023-12-16  6:16   ` Matthew Wilcox
2023-12-14 13:25 ` [PATCH 05/11] pagevec: Add ability to iterate a queue Christoph Hellwig
2023-12-14 13:25 ` [PATCH 06/11] writeback: Use the folio_batch queue iterator Christoph Hellwig
2023-12-14 13:25 ` [PATCH 07/11] writeback: Factor writeback_iter_init() out of write_cache_pages() Christoph Hellwig
2023-12-14 13:25 ` [PATCH 08/11] writeback: Factor writeback_get_folio() " Christoph Hellwig
2023-12-14 13:25 ` [PATCH 09/11] writeback: Factor writeback_iter_next() " Christoph Hellwig
2023-12-15 14:17   ` Brian Foster
2023-12-16  4:51     ` Christoph Hellwig
2023-12-14 13:25 ` [PATCH 10/11] writeback: Add for_each_writeback_folio() Christoph Hellwig
2023-12-14 13:25 ` [PATCH 11/11] writeback: Remove a use of write_cache_pages() from do_writepages() Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231214132544.376574-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).