linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>,
	Daejun Park <daejun7.park@samsung.com>,
	Kanchan Joshi <joshi.k@samsung.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Douglas Gilbert <dgilbert@interlog.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: [PATCH v6 14/20] scsi: scsi_debug: Support the block limits extension VPD page
Date: Thu, 14 Dec 2023 12:40:47 -0800	[thread overview]
Message-ID: <20231214204119.3670625-15-bvanassche@acm.org> (raw)
In-Reply-To: <20231214204119.3670625-1-bvanassche@acm.org>

From SBC-5 r05:

"Reduced stream control:
a) reduces the maximum number of streams that the device server supports;
   and
b) increases the number of write commands that are able to specify a stream
   to be written in any write command that contains the GROUP NUMBER field
   in its CDB.

If the RSCS bit (see 6.6.5) is set to one, then the device server shall:
a) support per group stream identifier usage as described in 4.32.2;
b) support the IO Advice Hints Grouping mode page (see 6.5.7); and
c) set the MAXIMUM NUMBER OF STREAMS field (see 6.6.5) to a value that is
   less than 64.

Device servers that set the RSCS bit to one may support other features
(e.g., permanent streams (see 4.32.4)).

4.32.4 Permanent streams

A permanent stream is a stream for which the device server does not allow
closing or otherwise modifying the configuration of that stream. The PERM
bit (see 5.9.2.3) indicates whether a stream is a permanent stream. If a
STREAM CONTROL command (see 5.32) specifies the closing of a permanent
stream, the device server terminates that command with CHECK CONDITION
status instead of closing the specified stream. A permanent stream is always
an open stream. Device severs should assign the lowest numbered stream
identifiers to permanent streams."

Report that reduced stream control is supported.

Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Tested-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/scsi/scsi_debug.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 5cf337ba9c19..39f8ae4dce82 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -1873,6 +1873,19 @@ static int inquiry_vpd_b6(struct sdebug_dev_info *devip, unsigned char *arr)
 	return 0x3c;
 }
 
+#define SDEBUG_BLE_LEN_AFTER_B4 28	/* thus vpage 32 bytes long */
+
+enum { MAXIMUM_NUMBER_OF_STREAMS = 6, PERMANENT_STREAM_COUNT = 5 };
+
+/* Block limits extension VPD page (SBC-4) */
+static int inquiry_vpd_b7(unsigned char *arrb4)
+{
+	memset(arrb4, 0, SDEBUG_BLE_LEN_AFTER_B4);
+	arrb4[1] = 1; /* Reduced stream control support (RSCS) */
+	put_unaligned_be16(MAXIMUM_NUMBER_OF_STREAMS, &arrb4[2]);
+	return SDEBUG_BLE_LEN_AFTER_B4;
+}
+
 #define SDEBUG_LONG_INQ_SZ 96
 #define SDEBUG_MAX_INQ_ARR_SZ 584
 
@@ -1938,6 +1951,7 @@ static int resp_inquiry(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
 					arr[n++] = 0xb2;  /* LB Provisioning */
 				if (is_zbc)
 					arr[n++] = 0xb6;  /* ZB dev. char. */
+				arr[n++] = 0xb7;  /* Block limits extension */
 			}
 			arr[3] = n - 4;	  /* number of supported VPD pages */
 		} else if (0x80 == cmd[2]) { /* unit serial number */
@@ -1980,6 +1994,8 @@ static int resp_inquiry(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
 			arr[3] = inquiry_vpd_b2(&arr[4]);
 		} else if (is_zbc && cmd[2] == 0xb6) { /* ZB dev. charact. */
 			arr[3] = inquiry_vpd_b6(devip, &arr[4]);
+		} else if (cmd[2] == 0xb7) { /* block limits extension page */
+			arr[3] = inquiry_vpd_b7(&arr[4]);
 		} else {
 			mk_sense_invalid_fld(scp, SDEB_IN_CDB, 2, -1);
 			kfree(arr);

  parent reply	other threads:[~2023-12-14 20:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 20:40 [PATCH v6 00/20] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 01/20] fs: Fix rw_hint validation Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 02/20] fs: Verify write lifetime constants at compile time Bart Van Assche
2023-12-15  7:21   ` Christoph Hellwig
2023-12-15 14:13   ` Johannes Thumshirn
2023-12-14 20:40 ` [PATCH v6 03/20] fs: Split fcntl_rw_hint() Bart Van Assche
2023-12-15  7:21   ` Christoph Hellwig
2023-12-14 20:40 ` [PATCH v6 04/20] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-15  7:22   ` Christoph Hellwig
2023-12-14 20:40 ` [PATCH v6 05/20] fs: Restore F_[GS]ET_FILE_RW_HINT support Bart Van Assche
2023-12-15  7:22   ` Christoph Hellwig
2023-12-15 10:19     ` Christian Brauner
2023-12-14 20:40 ` [PATCH v6 06/20] block, fs: Restore the per-bio/request data lifetime fields Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 07/20] block, fs: Propagate write hints to the block device inode Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 08/20] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 09/20] fs/f2fs: Restore support for tracing data lifetimes Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 10/20] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 11/20] scsi: scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 12/20] scsi: sd: Translate data lifetime information Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 13/20] scsi: scsi_debug: Reduce code duplication Bart Van Assche
2023-12-14 20:40 ` Bart Van Assche [this message]
2023-12-14 20:40 ` [PATCH v6 15/20] scsi: scsi_debug: Rework page code error handling Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 16/20] scsi: scsi_debug: Rework subpage " Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 17/20] scsi: scsi_debug: Allocate the MODE SENSE response from the heap Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 18/20] scsi: scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 19/20] scsi: scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 20/20] scsi: scsi_debug: Maintain write statistics per group number Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231214204119.3670625-15-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=daejun7.park@samsung.com \
    --cc=dgilbert@interlog.com \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).