From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Daejun Park <daejun7.park@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Bart Van Assche <bvanassche@acm.org>,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Dave Chinner <dchinner@redhat.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Subject: [PATCH v6 05/20] fs: Restore F_[GS]ET_FILE_RW_HINT support
Date: Thu, 14 Dec 2023 12:40:38 -0800 [thread overview]
Message-ID: <20231214204119.3670625-6-bvanassche@acm.org> (raw)
In-Reply-To: <20231214204119.3670625-1-bvanassche@acm.org>
Since there are applications (e.g. Ceph) that use F_[GS]ET_FILE_RW_HINT,
restore support for these fcntls. This patch restores functionality that
was removed by commit 7b12e49669c9 ("fs: remove fs.f_write_hint").
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <dchinner@redhat.com>
Cc: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
fs/fcntl.c | 37 +++++++++++++++++++++++++++++++++++++
fs/open.c | 1 +
include/linux/fs.h | 9 +++++++++
3 files changed, 47 insertions(+)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index fc73c5fae43c..8018c4da478c 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -322,6 +322,37 @@ static long fcntl_set_rw_hint(struct file *file, unsigned int cmd,
return 0;
}
+static long fcntl_get_file_rw_hint(struct file *file, unsigned int cmd,
+ unsigned long arg)
+{
+ struct inode *inode = file_inode(file);
+ u64 __user *argp = (u64 __user *)arg;
+ u64 hint = inode->i_write_hint;
+
+ hint = file_write_hint(file);
+ if (copy_to_user(argp, &hint, sizeof(*argp)))
+ return -EFAULT;
+ return 0;
+}
+
+static long fcntl_set_file_rw_hint(struct file *file, unsigned int cmd,
+ unsigned long arg)
+{
+ u64 __user *argp = (u64 __user *)arg;
+ u64 hint;
+
+ if (copy_from_user(&hint, argp, sizeof(hint)))
+ return -EFAULT;
+ if (!rw_hint_valid(hint))
+ return -EINVAL;
+
+ spin_lock(&file->f_lock);
+ file->f_write_hint = hint;
+ spin_unlock(&file->f_lock);
+
+ return 0;
+}
+
static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
struct file *filp)
{
@@ -430,6 +461,12 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
case F_SET_RW_HINT:
err = fcntl_set_rw_hint(filp, cmd, arg);
break;
+ case F_GET_FILE_RW_HINT:
+ err = fcntl_get_file_rw_hint(filp, cmd, arg);
+ break;
+ case F_SET_FILE_RW_HINT:
+ err = fcntl_set_file_rw_hint(filp, cmd, arg);
+ break;
default:
break;
}
diff --git a/fs/open.c b/fs/open.c
index 02dc608d40d8..4c5c29541ac5 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -961,6 +961,7 @@ static int do_dentry_open(struct file *f,
if (f->f_mapping->a_ops && f->f_mapping->a_ops->direct_IO)
f->f_mode |= FMODE_CAN_ODIRECT;
+ f->f_write_hint = WRITE_LIFE_NOT_SET;
f->f_flags &= ~(O_CREAT | O_EXCL | O_NOCTTY | O_TRUNC);
f->f_iocb_flags = iocb_flags(f);
diff --git a/include/linux/fs.h b/include/linux/fs.h
index a08014b68d6e..a6e0c4b5a72b 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -989,6 +989,7 @@ struct file {
* Must not be taken from IRQ context.
*/
spinlock_t f_lock;
+ enum rw_hint f_write_hint;
fmode_t f_mode;
atomic_long_t f_count;
struct mutex f_pos_lock;
@@ -2162,6 +2163,14 @@ static inline bool HAS_UNMAPPED_ID(struct mnt_idmap *idmap,
!vfsgid_valid(i_gid_into_vfsgid(idmap, inode));
}
+static inline enum rw_hint file_write_hint(struct file *file)
+{
+ if (file->f_write_hint != WRITE_LIFE_NOT_SET)
+ return file->f_write_hint;
+
+ return file_inode(file)->i_write_hint;
+}
+
static inline void init_sync_kiocb(struct kiocb *kiocb, struct file *filp)
{
*kiocb = (struct kiocb) {
next prev parent reply other threads:[~2023-12-14 20:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 20:40 [PATCH v6 00/20] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 01/20] fs: Fix rw_hint validation Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 02/20] fs: Verify write lifetime constants at compile time Bart Van Assche
2023-12-15 7:21 ` Christoph Hellwig
2023-12-15 14:13 ` Johannes Thumshirn
2023-12-14 20:40 ` [PATCH v6 03/20] fs: Split fcntl_rw_hint() Bart Van Assche
2023-12-15 7:21 ` Christoph Hellwig
2023-12-14 20:40 ` [PATCH v6 04/20] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-15 7:22 ` Christoph Hellwig
2023-12-14 20:40 ` Bart Van Assche [this message]
2023-12-15 7:22 ` [PATCH v6 05/20] fs: Restore F_[GS]ET_FILE_RW_HINT support Christoph Hellwig
2023-12-15 10:19 ` Christian Brauner
2023-12-14 20:40 ` [PATCH v6 06/20] block, fs: Restore the per-bio/request data lifetime fields Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 07/20] block, fs: Propagate write hints to the block device inode Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 08/20] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 09/20] fs/f2fs: Restore support for tracing data lifetimes Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 10/20] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 11/20] scsi: scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 12/20] scsi: sd: Translate data lifetime information Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 13/20] scsi: scsi_debug: Reduce code duplication Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 14/20] scsi: scsi_debug: Support the block limits extension VPD page Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 15/20] scsi: scsi_debug: Rework page code error handling Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 16/20] scsi: scsi_debug: Rework subpage " Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 17/20] scsi: scsi_debug: Allocate the MODE SENSE response from the heap Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 18/20] scsi: scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 19/20] scsi: scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-12-14 20:40 ` [PATCH v6 20/20] scsi: scsi_debug: Maintain write statistics per group number Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214204119.3670625-6-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=daejun7.park@samsung.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=joshi.k@samsung.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).