From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 733B231A63 for ; Fri, 15 Dec 2023 14:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toxicpanda.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20230601.gappssmtp.com header.i=@toxicpanda-com.20230601.gappssmtp.com header.b="fsH9Fsk+" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5cd81e76164so6241307b3.1 for ; Fri, 15 Dec 2023 06:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1702650392; x=1703255192; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+4V/xtuU5RtW7auv55nECI5YJaBifIHvReIdoO950Ik=; b=fsH9Fsk+hk7UK5xelpzTDhf5qmKjvpAZPUx1iXrFy36UHS/i+FyVliO8ZiK7Bnuv3p bgvDGF0P6UVVryG1F/tcbB29gUoDjTWl6/AvPUMDxV18bfXrdEjhY+iX6e+qN2NH33Je VVjopa6B+3wW3eegOGIhbAyVvIyM35KyY7JBrV6jykv6ZTV8cohDxee+uq6tG+3Ryndv z6O3MbJa4faLHIxdSG0Jp7e60zqbnMP1CJ1RSNxp1TB0Y7KD3RMThNId69csBgew3jM0 /UtFD22qUqm1jozA77C2TEN1uM4HSuhewNEBcGNfCsgjWeK7QVwaITyQzX+2/Fxwd/I/ X07A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702650392; x=1703255192; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+4V/xtuU5RtW7auv55nECI5YJaBifIHvReIdoO950Ik=; b=VmM0CiAQOvy64u2vk9yUFQZgH8I6sF0Y/zr5REhXNr/bsbWYNelhfxjycYymeIexay cbnj7+zXHUVbe5WUNQoZQo2d0FmRv80w8WYVhcE0C92F6ZnNc4ErLRyWoQcQbhS7YQHN 31l+abx6eipnLUjpKSzgfwDO6pvIsaR/hcKLHt3hBIDExL749pAe9raav4lQObFHBErR Bv2ZTWR94JjVX+Pw1A+czpb/0jfQ5p+22BMlwIPRQ29OLKGI9hk2c6+0s3Y+SMDXH0Lg PHaRzCMQ8Xqex8XvX7GohUkEQEjkEnX/epS5+SPPxzgUBlc87SHpm2PVzh0WTqiz4SIT y6+g== X-Gm-Message-State: AOJu0YxGGAyjtzAqzjhHqLoryG6DzfwgGpEHFTN+yzaC9090vYElXaPi o64PSf1Wnlm5sZOwAaFf1ycgUg== X-Google-Smtp-Source: AGHT+IGpj2fZ4DlpWbI9o2AbVXyl3n081P7woEHQN+l8wabNi4vE8R5e3ZFfwi7WbmH7RL0B6LtbAw== X-Received: by 2002:a0d:d812:0:b0:5e3:347b:e864 with SMTP id a18-20020a0dd812000000b005e3347be864mr3181497ywe.26.1702650392430; Fri, 15 Dec 2023 06:26:32 -0800 (PST) Received: from localhost (076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id x8-20020a814a08000000b005d3b4fce438sm6269510ywa.65.2023.12.15.06.26.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:26:31 -0800 (PST) Date: Fri, 15 Dec 2023 09:26:30 -0500 From: Josef Bacik To: Christoph Hellwig Cc: Eric Biggers , linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Christian Brauner Subject: Re: [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb Message-ID: <20231215142630.GB683314@perftesting> References: <20231213040018.73803-1-ebiggers@kernel.org> <20231213040018.73803-2-ebiggers@kernel.org> <20231213084123.GA6184@lst.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213084123.GA6184@lst.de> On Wed, Dec 13, 2023 at 09:41:23AM +0100, Christoph Hellwig wrote: > On Tue, Dec 12, 2023 at 08:00:16PM -0800, Eric Biggers wrote: > > From: Christoph Hellwig > > > > blkdev_put must not be called under sb->s_umount to avoid a lock order > > reversal with disk->open_mutex once call backs from block devices to > > the file system using the holder ops are supported. Move the call > > to btrfs_close_devices into btrfs_free_fs_info so that it is closed > > from ->kill_sb (which is also called from the mount failure handling > > path unlike ->put_super) as well as when an fs_info is freed because > > an existing superblock already exists. > > Thanks, this looks roughly the same to what I have locally. > > I did in fact forward port everything missing from the get_super > series yesterday, but on my test setup btrfs/142 hangs even in the > baseline setup. I went back to Linux before giving up for now. > > Josef, any chane you could throw this branch: > > git://git.infradead.org/users/hch/misc.git btrfs-holder > > into your CI setup and see if it sticks? Except for the trivial last > three patches this is basically what you reviewed already, although > there was some heavy rebasing due to the mount API converison. > Yup, sorry Christoph I missed this email when you sent it, I'll throw it in there now. Thanks, Josef