From: Gabriel Krisman Bertazi <krisman@suse.de>
To: viro@zeniv.linux.org.uk, ebiggers@kernel.org, jaegeuk@kernel.org,
tytso@mit.edu
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@suse.de>
Subject: [PATCH v2 0/8] Revert setting casefolding dentry operations through s_d_op
Date: Fri, 15 Dec 2023 16:16:00 -0500 [thread overview]
Message-ID: <20231215211608.6449-1-krisman@suse.de> (raw)
[Apologies for the quick spin of a v2. The only difference are a couple
fixes to the build when CONFIG_UNICODE=n caught by LKP and detailed in
each patch changelog.]
When case-insensitive and fscrypt were adapted to work together, we moved the
code that sets the dentry operations for case-insensitive dentries(d_hash and
d_compare) to happen from a helper inside ->lookup. This is because fscrypt
wants to set d_revalidate only on some dentries, so it does it only for them in
d_revalidate.
But, case-insensitive hooks are actually set on all dentries in the filesystem,
so the natural place to do it is through s_d_op and let d_alloc handle it [1].
In addition, doing it inside the ->lookup is a problem for case-insensitive
dentries that are not created through ->lookup, like those coming
open-by-fhandle[2], which will not see the required d_ops.
This patchset therefore reverts to using sb->s_d_op to set the dentry operations
for case-insensitive filesystems. In order to set case-insensitive hooks early
and not require every dentry to have d_revalidate in case-insensitive
filesystems, it introduces a patch suggested by Al Viro to disable d_revalidate
on some dentries on the fly.
It survives fstests encrypt and quick groups without regressions. Based on
v6.7-rc1.
[1] https://lore.kernel.org/linux-fsdevel/20231123195327.GP38156@ZenIV/
[2] https://lore.kernel.org/linux-fsdevel/20231123171255.GN38156@ZenIV/
Gabriel Krisman Bertazi (8):
dcache: Add helper to disable d_revalidate for a specific dentry
fscrypt: Drop d_revalidate if key is available
libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops
libfs: Expose generic_ci_dentry_ops outside of libfs
ext4: Set the case-insensitive dentry operations through ->s_d_op
f2fs: Set the case-insensitive dentry operations through ->s_d_op
libfs: Don't support setting casefold operations during lookup
fscrypt: Move d_revalidate configuration back into fscrypt
fs/crypto/fname.c | 9 +++++-
fs/crypto/hooks.c | 8 +++++
fs/dcache.c | 10 +++++++
fs/ext4/namei.c | 1 -
fs/ext4/super.c | 5 ++++
fs/f2fs/namei.c | 1 -
fs/f2fs/super.c | 5 ++++
fs/libfs.c | 66 ++---------------------------------------
fs/ubifs/dir.c | 1 -
include/linux/dcache.h | 1 +
include/linux/fs.h | 2 +-
include/linux/fscrypt.h | 10 +++----
12 files changed, 45 insertions(+), 74 deletions(-)
--
2.43.0
next reply other threads:[~2023-12-15 21:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 21:16 Gabriel Krisman Bertazi [this message]
2023-12-15 21:16 ` [PATCH v2 1/8] dcache: Add helper to disable d_revalidate for a specific dentry Gabriel Krisman Bertazi
2023-12-15 21:16 ` [PATCH v2 2/8] fscrypt: Drop d_revalidate if key is available Gabriel Krisman Bertazi
2023-12-19 23:00 ` Eric Biggers
2023-12-21 7:14 ` Al Viro
2023-12-21 7:19 ` Al Viro
2023-12-15 21:16 ` [PATCH v2 3/8] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops Gabriel Krisman Bertazi
2023-12-19 22:55 ` Eric Biggers
2023-12-15 21:16 ` [PATCH v2 4/8] libfs: Expose generic_ci_dentry_ops outside of libfs Gabriel Krisman Bertazi
2023-12-19 22:56 ` Eric Biggers
2023-12-15 21:16 ` [PATCH v2 5/8] ext4: Set the case-insensitive dentry operations through ->s_d_op Gabriel Krisman Bertazi
2023-12-15 21:16 ` [PATCH v2 6/8] f2fs: " Gabriel Krisman Bertazi
2023-12-15 21:16 ` [PATCH v2 7/8] libfs: Don't support setting casefold operations during lookup Gabriel Krisman Bertazi
2023-12-15 21:16 ` [PATCH v2 8/8] fscrypt: Move d_revalidate configuration back into fscrypt Gabriel Krisman Bertazi
2023-12-19 23:03 ` Eric Biggers
2023-12-21 7:39 ` Al Viro
2023-12-22 5:58 ` Eric Biggers
2023-12-19 23:12 ` [PATCH v2 0/8] Revert setting casefolding dentry operations through s_d_op Eric Biggers
2023-12-23 4:23 ` [PATCH] ovl: Reject mounting case-insensitive filesystems Gabriel Krisman Bertazi
2023-12-23 6:20 ` Amir Goldstein
2023-12-23 6:22 ` Amir Goldstein
2023-12-23 12:46 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215211608.6449-1-krisman@suse.de \
--to=krisman@suse.de \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).