From: Christoph Hellwig <hch@lst.de>
To: Josef Bacik <josef@toxicpanda.com>
Cc: Christoph Hellwig <hch@lst.de>,
Eric Biggers <ebiggers@kernel.org>,
Christian Brauner <brauner@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb
Date: Sat, 16 Dec 2023 05:12:21 +0100 [thread overview]
Message-ID: <20231216041221.GA8850@lst.de> (raw)
In-Reply-To: <20231215214550.GB883762@perftesting>
On Fri, Dec 15, 2023 at 04:45:50PM -0500, Josef Bacik wrote:
> I ran it through, you broke a test that isn't upstream yet to test the old mount
> api double mount thing that I have a test for
>
> https://github.com/btrfs/fstests/commit/2796723e77adb0f9da1059acf13fc402467f7ac4
>
> In this case we end up leaking a reference on the fs_devices. If you add this
> fixup to "btrfs: call btrfs_close_devices from ->kill_sb" it fixes that failure.
> I'm re-running with that fixup applied, but I assume the rest is fine. Thanks,
Is "this fixup" referring to a patch that was supposed to be attached
but is't? :)
next prev parent reply other threads:[~2023-12-16 4:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 4:00 [PATCH 0/3] Move fscrypt keyring destruction to after ->put_super Eric Biggers
2023-12-13 4:00 ` [PATCH 1/3] btrfs: call btrfs_close_devices from ->kill_sb Eric Biggers
2023-12-13 8:41 ` Christoph Hellwig
2023-12-15 14:26 ` Josef Bacik
2023-12-15 21:45 ` [f2fs-dev] " Josef Bacik
2023-12-16 4:12 ` Christoph Hellwig [this message]
2023-12-16 14:52 ` Josef Bacik
2023-12-13 4:00 ` [PATCH 2/3] f2fs: move release of block devices to after kill_block_super() Eric Biggers
2023-12-27 4:47 ` Eric Biggers
2023-12-27 7:10 ` [f2fs-dev] " Chao Yu
2023-12-13 4:00 ` [PATCH 3/3] fs: move fscrypt keyring destruction to after ->put_super Eric Biggers
2023-12-13 16:15 ` Christoph Hellwig
2023-12-13 20:54 ` Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231216041221.GA8850@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).