From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90AD811187; Sat, 16 Dec 2023 04:29:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 8967F68B05; Sat, 16 Dec 2023 05:29:16 +0100 (CET) Date: Sat, 16 Dec 2023 05:29:16 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 03/14] fs: Reduce stack usage in __mpage_writepage Message-ID: <20231216042916.GC9284@lst.de> References: <20231215200245.748418-1-willy@infradead.org> <20231215200245.748418-4-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231215200245.748418-4-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Dec 15, 2023 at 08:02:34PM +0000, Matthew Wilcox (Oracle) wrote: > Some architectures support a very large PAGE_SIZE, so instead of the 8 > pointers we see with a 4kB PAGE_SIZE, we can see 128 pointers with 64kB > or so many on Hexagon that it trips compiler warnings about exceeding > stack frame size. > > All we're doing with this array is checking for block contiguity, which we > can as well do by remembering the address of the first block in the page > and checking this block is at the appropriate offset from that address. Looks good: Reviewed-by: Christoph Hellwig