linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-mm@kvack.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Jan Kara <jack@suse.com>, David Howells <dhowells@redhat.com>,
	Brian Foster <bfoster@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Convert write_cache_pages() to an iterator v3
Date: Mon, 18 Dec 2023 16:35:36 +0100	[thread overview]
Message-ID: <20231218153553.807799-1-hch@lst.de> (raw)

Hi all,

this is basically a evolution of the series Matthew Wilcox originally
set in June.  Based on comments from Jan a Brian this now actually
untangles some of the more confusing conditional in the writeback code
before refactoring it into the iterator.  Because of that all the
later patches need a fair amount of rebasing and I've not carried any
reviewed-by over.

The original cover letter is below:

Dave Howells doesn't like the indirect function call imposed by
write_cache_pages(), so refactor it into an iterator.  I took the
opportunity to add the ability to iterate a folio_batch without having
an external variable.

This is against next-20230623.  If you try to apply it on top of a tree
which doesn't include the pagevec removal series, IT WILL CRASH because
it won't reinitialise folio_batch->i and the iteration will index out
of bounds.

I have a feeling the 'done' parameter could have a better name, but I
can't think what it might be.

Diffstat:
 include/linux/pagevec.h   |   18 ++
 include/linux/writeback.h |   19 ++
 mm/page-writeback.c       |  333 +++++++++++++++++++++++++---------------------
 3 files changed, 220 insertions(+), 150 deletions(-)

             reply	other threads:[~2023-12-18 15:36 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 15:35 Christoph Hellwig [this message]
2023-12-18 15:35 ` [PATCH 01/17] writeback: fix done_index when hitting the wbc->nr_to_write Christoph Hellwig
2023-12-19 17:33   ` Jan Kara
2023-12-18 15:35 ` [PATCH 02/17] writeback: also update wbc->nr_to_write on writeback failure Christoph Hellwig
2023-12-19 17:36   ` Jan Kara
2023-12-18 15:35 ` [PATCH 03/17] writeback: rework the loop termination condition in write_cache_pages Christoph Hellwig
2023-12-19 18:27   ` Jan Kara
2023-12-18 15:35 ` [PATCH 04/17] writeback: only update ->writeback_index for range_cyclic writeback Christoph Hellwig
2023-12-21 10:59   ` Jan Kara
2023-12-18 15:35 ` [PATCH 05/17] writeback: remove a duplicate prototype for tag_pages_for_writeback Christoph Hellwig
2023-12-21 10:59   ` Jan Kara
2023-12-18 15:35 ` [PATCH 06/17] writeback: Factor out writeback_finish() Christoph Hellwig
2023-12-21 11:09   ` Jan Kara
2023-12-18 15:35 ` [PATCH 07/17] writeback: Factor writeback_get_batch() out of write_cache_pages() Christoph Hellwig
2023-12-21 11:17   ` Jan Kara
2023-12-21 12:22     ` Christoph Hellwig
2023-12-21 12:30       ` Jan Kara
2023-12-18 15:35 ` [PATCH 08/17] writeback: Factor should_writeback_folio() " Christoph Hellwig
2023-12-21 11:22   ` Jan Kara
2023-12-21 12:23     ` Christoph Hellwig
2023-12-18 15:35 ` [PATCH 09/17] writeback: Simplify the loops in write_cache_pages() Christoph Hellwig
2023-12-21 11:24   ` Jan Kara
2023-12-18 15:35 ` [PATCH 10/17] pagevec: Add ability to iterate a queue Christoph Hellwig
2023-12-21 11:26   ` Jan Kara
2023-12-18 15:35 ` [PATCH 11/17] writeback: Use the folio_batch queue iterator Christoph Hellwig
2023-12-21 11:28   ` Jan Kara
2023-12-18 15:35 ` [PATCH 12/17] writeback: Factor writeback_iter_init() out of write_cache_pages() Christoph Hellwig
2023-12-21 11:29   ` Jan Kara
2023-12-18 15:35 ` [PATCH 13/17] writeback: Factor writeback_get_folio() " Christoph Hellwig
2023-12-21 11:41   ` Jan Kara
2023-12-21 12:25     ` Christoph Hellwig
2023-12-21 12:31       ` Jan Kara
2023-12-18 15:35 ` [PATCH 14/17] writeback: Factor writeback_iter_next() " Christoph Hellwig
2023-12-21 11:46   ` Jan Kara
2023-12-18 15:35 ` [PATCH 15/17] writeback: Add for_each_writeback_folio() Christoph Hellwig
2023-12-21 11:51   ` Jan Kara
2023-12-21 12:29     ` Christoph Hellwig
2023-12-21 12:49       ` Jan Kara
2023-12-18 15:35 ` [PATCH 16/17] writeback: Remove a use of write_cache_pages() from do_writepages() Christoph Hellwig
2023-12-21 11:53   ` Jan Kara
2023-12-18 15:35 ` [PATCH 17/17] writeback: update the kerneldoc comment for tag_pages_for_writeback Christoph Hellwig
2023-12-21 11:54   ` Jan Kara
2023-12-18 21:00 ` Convert write_cache_pages() to an iterator v3 Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231218153553.807799-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=bfoster@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).