Re: [PATCH] sysctl: remove struct ctl_path

[Joel Granados <j.granados@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]

On Wed, Dec 20, 2023 at 10:23:35PM +0100, Thomas Weißschuh wrote:
> All usages of this struct have been removed from the kernel tree.
> 
> The struct is still referenced by scripts/check-sysctl-docs but that
> script is broken anyways as it only supports the register_sysctl_paths()
> API and not the currently used register_sysctl() one.
> 
> Fixes: 0199849acd07 ("sysctl: remove register_sysctl_paths()")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>  include/linux/sysctl.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
> index 61b40ea81f4d..8084e9132833 100644
> --- a/include/linux/sysctl.h
> +++ b/include/linux/sysctl.h
> @@ -210,11 +210,6 @@ struct ctl_table_root {
>  	int (*permissions)(struct ctl_table_header *head, struct ctl_table *table);
>  };
>  
> -/* struct ctl_path describes where in the hierarchy a table is added */
> -struct ctl_path {
> -	const char *procname;
> -};
> -
>  #define register_sysctl(path, table)	\
>  	register_sysctl_sz(path, table, ARRAY_SIZE(table))
>  
> 
> ---
> base-commit: 1a44b0073b9235521280e19d963b6dfef7888f18
> change-id: 20231220-sysctl-paths-474697856a3f
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
> 

LGTM
Reviewed-by: Joel Granados <j.granados@samsung.com>

-- 

Joel Granados

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]