From: Christian Brauner <brauner@kernel.org>
To: Gabriel Ryan <gabe@cs.columbia.edu>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-fsdevel@vger.kernel.org
Subject: Re: Race in fs/posix_acl.c posix_acl_update_mode and related checks on inode->i_mode in kernel v6.6
Date: Mon, 22 Jan 2024 16:10:35 +0100 [thread overview]
Message-ID: <20240122-summieren-einchecken-4d9d27edcacc@brauner> (raw)
In-Reply-To: <CALbthtcRoJ_mBRmEBUmyMDw-WPpLOyAEecpu6jj+1AFBEWrkoA@mail.gmail.com>
On Fri, Jan 19, 2024 at 10:24:59AM -0500, Gabriel Ryan wrote:
> Thank you for your response Christian. I reported the race because it
> appeared potentially harmful, but based on your response it sounds like the
> race is almost certainly benign, and any potential issues would be
> addressed with WRITE_ONCE() as you suggest.
Ok. What I'm asking is whether you can confirm that the thing that your
tool discovered is indeed a WRITE_ONCE() issue. Is there any trace and
any more details?
prev parent reply other threads:[~2024-01-22 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 16:30 Race in fs/posix_acl.c posix_acl_update_mode and related checks on inode->i_mode in kernel v6.6 Gabriel Ryan
2024-01-19 15:04 ` Christian Brauner
[not found] ` <CALbthtcRoJ_mBRmEBUmyMDw-WPpLOyAEecpu6jj+1AFBEWrkoA@mail.gmail.com>
2024-01-22 15:10 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122-summieren-einchecken-4d9d27edcacc@brauner \
--to=brauner@kernel.org \
--cc=gabe@cs.columbia.edu \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox