From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5CE1125C8; Thu, 25 Jan 2024 23:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706224907; cv=none; b=XpGBGNI1vaLr5f//ijC4uZIbuODSqzgjKLX3IRfHJkhNcKKz9PlUGhNX/TXLZdueWbP52tl1yYlBQlHd8SLnRf+mCTk6F4rjN0eKMBVCByh8g4KyyydPGIqWAQYcbUU99yVksmqyAJieEO0+/kEYYePn9Abo6dwNCLDctSyNfHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706224907; c=relaxed/simple; bh=guOzA7K6RUgZ5DDnCdKRtRAA0JyuY3NLLW25sX22Xag=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lSG0rjoY2ekWMQ4ZfoeHgEUYKTzxiDWwEEpxNO7ozomI/XP8KQOmad/71+G8x9psRYpZfO69VyF0+c5O7aR4FLkApGQX2ynLBaaEeO5GFaRwyjhWhbuoC8pW6+n6X8pqo8rNEf/6TCJozEaS+0uTMJOuNsoqTt0jZqn6aCI9vSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mmh748ud; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mmh748ud" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C0D5C433F1; Thu, 25 Jan 2024 23:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706224907; bh=guOzA7K6RUgZ5DDnCdKRtRAA0JyuY3NLLW25sX22Xag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mmh748ud3Gbon2Ah/b3OsL3op+RJWgcz/46gD1rs+N4tL7aFMhUVtB35T6Q7ZkZLk MyK6EXm41JZzMkPYFIg8S4J/tJrO6Y8wOMWcqJ3AJKkKDEXINxS8IJocZvjfXwOGkc ZeIjPEfvazV/u8gDk26Xz1/ly4mTgfFP5peIqDUU= Date: Thu, 25 Jan 2024 15:21:46 -0800 From: Greg Kroah-Hartman To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, kuba@kernel.org, willemdebruijn.kernel@gmail.com, weiwan@google.com, Jonathan Corbet , Alexander Viro , Jan Kara , Michael Ellerman , Nathan Lynch , Steve French , Thomas Zimmermann , Jiri Slaby , Julien Panis , Arnd Bergmann , Andrew Waterman , Thomas Huth , Palmer Dabbelt , "open list:DOCUMENTATION" , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH net-next v3 3/3] eventpoll: Add epoll ioctl for epoll_params Message-ID: <2024012551-anyone-demeaning-867b@gregkh> References: <20240125225704.12781-1-jdamato@fastly.com> <20240125225704.12781-4-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240125225704.12781-4-jdamato@fastly.com> On Thu, Jan 25, 2024 at 10:56:59PM +0000, Joe Damato wrote: > +struct epoll_params { > + u64 busy_poll_usecs; > + u16 busy_poll_budget; > + > + /* for future fields */ > + u8 data[118]; > +} EPOLL_PACKED; variables that cross the user/kernel boundry need to be __u64, __u16, and __u8 here. And why 118? thanks, greg k-h