From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F19C254730; Tue, 30 Jan 2024 08:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706602411; cv=none; b=qHxlMfGL08jQ/3HCHehQ4algUjfl6TDNMg/Dv6lQ+8cRXfyarRG52UB/2axgYeohewDirNsCtClUPM5igJdy18Woj9zS6j+oKHlnfkpB/9jl8OVtvhNvoTInZKp+NO5C4i1rq8ltClMqRq8i1DVQtOxrJtEbNZudX7sh7E4dkXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706602411; c=relaxed/simple; bh=H9Uzgoak4i6LUsljZliictwGDjYmDADI3JxrR/uu71w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qCFordJfAbkxKvPQhCnr4cZA51bl1bWkwbzQnNnHMMv4lkIWDJX1krawbEml5uBmnSwU2c8pRjdJJkc9ForVk9Gdt2sk5ECCRR/Z0Hh7ctkmXaClvSdLNX6VAyj8Urgcc4DlPiGnOzeIreruX2UMKF7Sri1meI5xhPQXxwtqEBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id E3FF368C4E; Tue, 30 Jan 2024 09:13:26 +0100 (CET) Date: Tue, 30 Jan 2024 09:13:25 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 3/3] ext4: Convert to buffered_write_operations Message-ID: <20240130081325.GD22621@lst.de> References: <20240130055414.2143959-1-willy@infradead.org> <20240130055414.2143959-4-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130055414.2143959-4-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Given that an ext4 conversion to iomap is pending on the list I wonder if this is the best example. But the conversion itself looks sensible to me with the fixup.