From: Bart Van Assche <bvanassche@acm.org>
To: Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>,
Kanchan Joshi <joshi.k@samsung.com>,
Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH 5/6] fs: Propagate write hints to the struct block_device inode
Date: Wed, 31 Jan 2024 12:52:36 -0800 [thread overview]
Message-ID: <20240131205237.3540210-6-bvanassche@acm.org> (raw)
In-Reply-To: <20240131205237.3540210-1-bvanassche@acm.org>
Write hints applied with F_SET_RW_HINT on a block device affect the
block device inode only. Propagate these hints to the inode associated
with struct block_device because that is the inode used when writing
back dirty pages.
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
fs/fcntl.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index fc73c5fae43c..cfb52c3a4577 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -319,6 +319,17 @@ static long fcntl_set_rw_hint(struct file *file, unsigned int cmd,
inode->i_write_hint = hint;
inode_unlock(inode);
+ /*
+ * file->f_mapping->host may differ from inode. As an example,
+ * blkdev_open() modifies file->f_mapping.
+ */
+ if (file->f_mapping->host != inode) {
+ inode = file->f_mapping->host;
+ inode_lock(inode);
+ inode->i_write_hint = hint;
+ inode_unlock(inode);
+ }
+
return 0;
}
next prev parent reply other threads:[~2024-01-31 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 20:52 [PATCH 0/6] Restore data lifetime support Bart Van Assche
2024-01-31 20:52 ` [PATCH 1/6] fs: Fix rw_hint validation Bart Van Assche
2024-01-31 20:52 ` [PATCH 2/6] fs: Verify write lifetime constants at compile time Bart Van Assche
2024-01-31 20:52 ` [PATCH 3/6] fs: Split fcntl_rw_hint() Bart Van Assche
2024-01-31 21:07 ` Dave Chinner
2024-02-01 17:38 ` Bart Van Assche
2024-01-31 20:52 ` [PATCH 4/6] fs: Move enum rw_hint into a new header file Bart Van Assche
2024-01-31 20:52 ` Bart Van Assche [this message]
2024-01-31 20:52 ` [PATCH 6/6] block, fs: Restore the per-bio/request data lifetime fields Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131205237.3540210-6-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=joshi.k@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).