From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Dave Kleikamp <shaggy@kernel.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
jfs-discussion@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 04/13] jfs: Convert insert_metapage() to take a folio
Date: Thu, 1 Feb 2024 22:45:53 +0000 [thread overview]
Message-ID: <20240201224605.4055895-5-willy@infradead.org> (raw)
In-Reply-To: <20240201224605.4055895-1-willy@infradead.org>
Both of its callers now have a folio, so convert this function.
Use folio_attach_private() instead of manually setting folio->private.
This also gets the expected refcount of the folio correct.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/jfs/jfs_metapage.c | 31 +++++++++++++------------------
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
index 4ef85e264f51..6fa7023f5bc9 100644
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
@@ -87,25 +87,23 @@ static inline struct metapage *page_to_mp(struct page *page, int offset)
return mp_anchor(page)->mp[offset >> L2PSIZE];
}
-static inline int insert_metapage(struct page *page, struct metapage *mp)
+static inline int insert_metapage(struct folio *folio, struct metapage *mp)
{
struct meta_anchor *a;
int index;
int l2mp_blocks; /* log2 blocks per metapage */
- if (PagePrivate(page))
- a = mp_anchor(page);
- else {
+ a = folio->private;
+ if (!a) {
a = kzalloc(sizeof(struct meta_anchor), GFP_NOFS);
if (!a)
return -ENOMEM;
- set_page_private(page, (unsigned long)a);
- SetPagePrivate(page);
- kmap(page);
+ folio_attach_private(folio, a);
+ kmap(&folio->page);
}
if (mp) {
- l2mp_blocks = L2PSIZE - page->mapping->host->i_blkbits;
+ l2mp_blocks = L2PSIZE - folio->mapping->host->i_blkbits;
index = (mp->index >> l2mp_blocks) & (MPS_PER_PAGE - 1);
a->mp_count++;
a->mp[index] = mp;
@@ -127,8 +125,7 @@ static inline void remove_metapage(struct page *page, struct metapage *mp)
a->mp[index] = NULL;
if (--a->mp_count == 0) {
kfree(a);
- set_page_private(page, 0);
- ClearPagePrivate(page);
+ detach_page_private(page);
kunmap(page);
}
}
@@ -150,20 +147,18 @@ static inline struct metapage *page_to_mp(struct page *page, int offset)
return PagePrivate(page) ? (struct metapage *)page_private(page) : NULL;
}
-static inline int insert_metapage(struct page *page, struct metapage *mp)
+static inline int insert_metapage(struct folio *folio, struct metapage *mp)
{
if (mp) {
- set_page_private(page, (unsigned long)mp);
- SetPagePrivate(page);
- kmap(page);
+ folio_attach_private(folio, mp);
+ kmap(&folio->page);
}
return 0;
}
static inline void remove_metapage(struct page *page, struct metapage *mp)
{
- set_page_private(page, 0);
- ClearPagePrivate(page);
+ detach_page_private(page);
kunmap(page);
}
@@ -496,7 +491,7 @@ static int metapage_read_folio(struct file *fp, struct folio *folio)
&xlen);
if (pblock) {
if (!folio->private)
- insert_metapage(&folio->page, NULL);
+ insert_metapage(folio, NULL);
inc_io(&folio->page);
if (bio)
submit_bio(bio);
@@ -658,7 +653,7 @@ struct metapage *__get_metapage(struct inode *inode, unsigned long lblock,
mp->logical_size = size;
mp->data = folio_address(folio) + page_offset;
mp->index = lblock;
- if (unlikely(insert_metapage(&folio->page, mp))) {
+ if (unlikely(insert_metapage(folio, mp))) {
free_metapage(mp);
goto unlock;
}
--
2.43.0
next prev parent reply other threads:[~2024-02-01 22:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 22:45 [PATCH 00/13] JFS folio conversion Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 01/13] jfs: Convert metapage_read_folio to use folio APIs Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 02/13] jfs: Convert metapage_writepage to metapage_write_folio Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 03/13] jfs: Convert __get_metapage to use a folio Matthew Wilcox (Oracle)
2024-02-01 22:45 ` Matthew Wilcox (Oracle) [this message]
2024-02-01 22:45 ` [PATCH 05/13] jfs; Convert release_metapage " Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 06/13] jfs: Convert drop_metapage and remove_metapage to take " Matthew Wilcox (Oracle)
2024-02-02 17:18 ` kernel test robot
2024-02-05 11:29 ` kernel test robot
2024-02-01 22:45 ` [PATCH 07/13] jfs: Convert dec_io " Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 08/13] jfs; Convert __invalidate_metapages to use " Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 09/13] jfs: Convert page_to_mp to folio_to_mp Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 10/13] jfs: Convert inc_io and mp_anchor to take a folio Matthew Wilcox (Oracle)
2024-02-03 1:53 ` kernel test robot
2024-02-01 22:46 ` [PATCH 11/13] jfs: Convert force_metapage to use " Matthew Wilcox (Oracle)
2024-02-01 22:46 ` [PATCH 12/13] jfs: Change metapage->page to metapage->folio Matthew Wilcox (Oracle)
2024-02-01 22:46 ` [PATCH 13/13] fs: Remove i_blocks_per_page Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201224605.4055895-5-willy@infradead.org \
--to=willy@infradead.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shaggy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).