From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Dave Kleikamp <shaggy@kernel.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
jfs-discussion@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 08/13] jfs; Convert __invalidate_metapages to use a folio
Date: Thu, 1 Feb 2024 22:45:57 +0000 [thread overview]
Message-ID: <20240201224605.4055895-9-willy@infradead.org> (raw)
In-Reply-To: <20240201224605.4055895-1-willy@infradead.org>
Retrieve a folio from the page cache instead of a page. Saves a
couple of calls to compound_head().
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/jfs/jfs_metapage.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
index 552e6e97537c..2eb9db0184c1 100644
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
@@ -791,7 +791,6 @@ void __invalidate_metapages(struct inode *ip, s64 addr, int len)
struct address_space *mapping =
JFS_SBI(ip->i_sb)->direct_inode->i_mapping;
struct metapage *mp;
- struct page *page;
unsigned int offset;
/*
@@ -800,11 +799,12 @@ void __invalidate_metapages(struct inode *ip, s64 addr, int len)
*/
for (lblock = addr & ~(BlocksPerPage - 1); lblock < addr + len;
lblock += BlocksPerPage) {
- page = find_lock_page(mapping, lblock >> l2BlocksPerPage);
- if (!page)
+ struct folio *folio = filemap_lock_folio(mapping,
+ lblock >> l2BlocksPerPage);
+ if (IS_ERR(folio))
continue;
for (offset = 0; offset < PAGE_SIZE; offset += PSIZE) {
- mp = page_to_mp(page, offset);
+ mp = page_to_mp(&folio->page, offset);
if (!mp)
continue;
if (mp->index < addr)
@@ -817,8 +817,8 @@ void __invalidate_metapages(struct inode *ip, s64 addr, int len)
if (mp->lsn)
remove_from_logsync(mp);
}
- unlock_page(page);
- put_page(page);
+ folio_unlock(folio);
+ folio_put(folio);
}
}
--
2.43.0
next prev parent reply other threads:[~2024-02-01 22:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 22:45 [PATCH 00/13] JFS folio conversion Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 01/13] jfs: Convert metapage_read_folio to use folio APIs Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 02/13] jfs: Convert metapage_writepage to metapage_write_folio Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 03/13] jfs: Convert __get_metapage to use a folio Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 04/13] jfs: Convert insert_metapage() to take " Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 05/13] jfs; Convert release_metapage to use " Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 06/13] jfs: Convert drop_metapage and remove_metapage to take " Matthew Wilcox (Oracle)
2024-02-02 17:18 ` kernel test robot
2024-02-05 11:29 ` kernel test robot
2024-02-01 22:45 ` [PATCH 07/13] jfs: Convert dec_io " Matthew Wilcox (Oracle)
2024-02-01 22:45 ` Matthew Wilcox (Oracle) [this message]
2024-02-01 22:45 ` [PATCH 09/13] jfs: Convert page_to_mp to folio_to_mp Matthew Wilcox (Oracle)
2024-02-01 22:45 ` [PATCH 10/13] jfs: Convert inc_io and mp_anchor to take a folio Matthew Wilcox (Oracle)
2024-02-03 1:53 ` kernel test robot
2024-02-01 22:46 ` [PATCH 11/13] jfs: Convert force_metapage to use " Matthew Wilcox (Oracle)
2024-02-01 22:46 ` [PATCH 12/13] jfs: Change metapage->page to metapage->folio Matthew Wilcox (Oracle)
2024-02-01 22:46 ` [PATCH 13/13] fs: Remove i_blocks_per_page Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201224605.4055895-9-willy@infradead.org \
--to=willy@infradead.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shaggy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).