From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 746F012C7E5; Fri, 2 Feb 2024 18:50:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706899821; cv=none; b=nP8qBn2zhEmAd1KDzN+HNxLgyt8hy6oBYzau66g8p0NNThapxTGcpRVB2EO4FSeGRNn7aP1KbGLl0QImo1Z0RHKAM2gbTpz6v1iaxdWHP/agMf2v4e/gAxA+jCeZHZv5xnsNHVgq0k8OpwXFgeQ8EHdccnZ903RF17mFrosUFz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706899821; c=relaxed/simple; bh=fzeY1VlgvPi47dk0X+uJv+op+kqkPwqjm2YRFBDKUuY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n/4ADOJUSJXmx/vI2siVRWC7HNPWJT778i9E/uHtqs5H6lpim7dZSVycalXqf0HdVMTuSaVLhaaVcxauKLwbn7mA7ZRa9Ow1XtpzyQjq9nRqPwG/k2VaM+X5VkE939cM7iymTUXMpBiR+g6aGREDNrUUp22BqQBs9fEmX7p4u0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=fnIM5S8M; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="fnIM5S8M" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WB1XmSi8bTlEku4b4dtz4QsMpA2q7ThsMTrffyCD+dw=; b=fnIM5S8Mazi6ZPXYoBdBoOw+Tn 6tVuTorfFW591FhwOJRTmIR4vjOMMKPSWVMS9hBbdEaDHAFRZQtgaJ+HT0sH5po91vHLFvgsIcpM2 aeEhZz0xwwZ8p/nCTw+MeZ4tKcpODkFQwiIxfsYJjV/wwe/j5ufQ+LP2iDBzle+6VN1e7hOlF1OeI GqOooAiee9YkcDJS/RvhmfVaupqOvrLOGTY2lCWbNwmZtWUEsiSR+O7MiJcnhpHz9MLQwNYEmYKfA WFFyADeendL88hHn/pfqt8KzUEoLEYDkK+zWOQYhnJRgnzz4ugo8OzrfRmRTtWmiBliJ2Je6zv7i/ HRv+UOGQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rVyc6-004BKo-1h; Fri, 02 Feb 2024 18:50:10 +0000 Date: Fri, 2 Feb 2024 18:50:10 +0000 From: Al Viro To: Stefan Berger Cc: Amir Goldstein , Miklos Szeredi , Christian Brauner , Mimi Zohar , linux-unionfs@vger.kernel.org, linux-integrity@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/2] fs: remove the inode argument to ->d_real() method Message-ID: <20240202185010.GG2087318@ZenIV> References: <20240202110132.1584111-1-amir73il@gmail.com> <20240202110132.1584111-3-amir73il@gmail.com> <20240202160509.GZ2087318@ZenIV> <20240202161601.GA976131@ZenIV> <063577b8-3d7f-4a7f-8ed7-332601c98122@linux.ibm.com> <20240202182732.GE2087318@ZenIV> <4662633b-47c0-469f-9578-8597bcc65703@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4662633b-47c0-469f-9578-8597bcc65703@linux.ibm.com> Sender: Al Viro On Fri, Feb 02, 2024 at 01:32:39PM -0500, Stefan Berger wrote: > I can take it from here unless you want to formally post it. Less headache for me that way, but you want to test it - all I've checked is that the damn thing compiles, and while it's hard to fuck up and I don't see any brainos in there... I'm way too low on caffeine at the moment. It should be safe from races, just verifying that it prints the right thing when you hit that codepath would be enough.