linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-mm@kvack.org
Cc: Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.com>,
	David Howells <dhowells@redhat.com>,
	Brian Foster <bfoster@redhat.com>,
	Christian Brauner <brauner@kernel.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: convert write_cache_pages() to an iterator v6
Date: Sat,  3 Feb 2024 08:11:34 +0100	[thread overview]
Message-ID: <20240203071147.862076-1-hch@lst.de> (raw)

Hi all,

this is an evolution of the series Matthew Wilcox originally sent in June
2023, which has changed quite a bit since and now has a while based
iterator.

Note that in this version two patches are so different from the previous
version that I've not kept any Reviews or Acks for them, even if the
final result look almost the same as the previous patches with the
incremental patch on the list.

Changes since v5:
 - completely reshuffle the series to directly prepare for the
   writeback_iter() style.
 - don't require *error to be initialized on first call
 - improve various comments
 - fix a bisection hazard where write_cache_pages don't return delayed
   error for a few commits
 - fix a whitespace error
 - drop the iomap patch again for now as the iomap map multiple blocks
   series isn't in mainline yet

Changes since v4:
 - added back the (rebased) iomap conversion now that the conflict is in
   mainline
 - add a new patch to change the iterator

Changes since v3:
 - various commit log spelling fixes
 - remove a statement from a commit log that isn't true any more with the
   changes in v3
 - rename a function
 - merge two helpers

Diffstat:
 fs/iomap/buffered-io.c    |   10 -
 include/linux/pagevec.h   |   18 ++
 include/linux/writeback.h |   12 +
 mm/page-writeback.c       |  344 ++++++++++++++++++++++++++--------------------
 4 files changed, 231 insertions(+), 153 deletions(-)

             reply	other threads:[~2024-02-03  7:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-03  7:11 Christoph Hellwig [this message]
2024-02-03  7:11 ` [PATCH 01/13] writeback: remove a duplicate prototype for tag_pages_for_writeback Christoph Hellwig
2024-02-03  7:11 ` [PATCH 02/13] writeback: fix done_index when hitting the wbc->nr_to_write Christoph Hellwig
2024-02-03  7:11 ` [PATCH 03/13] writeback: also update wbc->nr_to_write on writeback failure Christoph Hellwig
2024-02-03  7:11 ` [PATCH 04/13] writeback: only update ->writeback_index for range_cyclic writeback Christoph Hellwig
2024-02-03  7:11 ` [PATCH 05/13] writeback: rework the loop termination condition in write_cache_pages Christoph Hellwig
2024-02-05 11:34   ` Jan Kara
2024-02-05 15:32   ` Brian Foster
2024-02-03  7:11 ` [PATCH 06/13] writeback: Factor folio_prepare_writeback() out of write_cache_pages() Christoph Hellwig
2024-02-03  7:11 ` [PATCH 07/13] writeback: Factor writeback_get_batch() " Christoph Hellwig
2024-02-03  7:11 ` [PATCH 08/13] writeback: Simplify the loops in write_cache_pages() Christoph Hellwig
2024-02-03  7:11 ` [PATCH 09/13] pagevec: Add ability to iterate a queue Christoph Hellwig
2024-02-03  7:11 ` [PATCH 10/13] writeback: Use the folio_batch queue iterator Christoph Hellwig
2024-02-03  7:11 ` [PATCH 11/13] writeback: Move the folio_prepare_writeback loop out of write_cache_pages() Christoph Hellwig
2024-02-03  7:11 ` [PATCH 12/13] writeback: add a writeback iterator Christoph Hellwig
2024-02-05 11:39   ` Jan Kara
2024-02-05 15:33   ` Brian Foster
2024-02-06 14:54     ` Brian Foster
2024-02-07  8:42       ` Jan Kara
2024-02-07 14:00         ` Brian Foster
2024-02-03  7:11 ` [PATCH 13/13] writeback: Remove a use of write_cache_pages() from do_writepages() Christoph Hellwig
2024-02-05 11:43   ` Jan Kara
2024-02-05 15:34   ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240203071147.862076-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=bfoster@redhat.com \
    --cc=brauner@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=djwong@kernel.org \
    --cc=jack@suse.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).