From: Christian Brauner <brauner@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Chuck Lever <chuck.lever@oracle.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] filelock: add stubs for new functions when CONFIG_FILE_LOCKING=n
Date: Mon, 5 Feb 2024 13:10:28 +0100 [thread overview]
Message-ID: <20240205-prall-herde-c413a323b54c@brauner> (raw)
In-Reply-To: <20240204-flsplit3-v1-1-9820c7d9ce16@kernel.org>
> Another thought too: "locks_" as a prefix is awfully generic. Might it be
> better to rename these new functions with a "filelock_" prefix instead?
> That would better distinguish to the casual reader that this is dealing
> with a file_lock object. I'm happy to respin the set if that's the
> consensus.
If it's just a rename then just point me to a branch I can pull. I don't
think it's worth resending just because you effectively did some variant
of s/lock_*/filelock_*/g
In any case, folded this one.
next prev parent reply other threads:[~2024-02-05 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 12:32 [PATCH] filelock: add stubs for new functions when CONFIG_FILE_LOCKING=n Jeff Layton
2024-02-04 23:43 ` Chuck Lever
2024-02-05 12:10 ` Christian Brauner [this message]
2024-02-05 12:20 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205-prall-herde-c413a323b54c@brauner \
--to=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).