Re: [PATCH v2 0/3] fs/exec: remove current->in_execve flag

Serge Hallyn
2024-02-05T03:35:06Z

On Sat, Feb 03, 2024 at 07:52:24PM +0900, Tetsuo Handa wrote:
> This is a follow up series for removing current->in_execve flag.
>
> https://lkml.kernel.org/r/b5a12ecd-468d-4b50-9f8c-17ae2a2560b4@I-love.SAKURA.ne.jp
>
> [PATCH v2 1/3] LSM: add security_execve_abort() hook
> [PATCH v2 2/3] tomoyo: replace current->in_execve flag with security_execve_abort() hook
> [PATCH v2 3/3] fs/exec: remove current->in_execve flag
>
> fs/exec.c | 4 +---
> include/linux/lsm_hook_defs.h | 1 +
> include/linux/sched.h | 3 ---
> include/linux/security.h | 5 +++++
> security/security.c | 11 +++++++++++
> security/tomoyo/tomoyo.c | 22 ++++++----------------
> 6 files changed, 24 insertions(+), 22 deletions(-)
>
> Changes in v2:
>
> Replace security_bprm_aborting_creds(const struct linux_binprm *bprm) with
> security_execve_abort(void), suggested by Eric W. Biederman.

It seems good to me, apart from the mistaken bprm arg mention in
tomoyo_execve_abort() comment in patch 2 which kernel-test-robot found.

Acked-by: Serge E. Hallyn <serge@hallyn.com>

thanks,
-serge