Re: [PATCH v2 2/3] tomoyo: replace current->in_execve flag with security_execve_abort() hook

kernel test robot
2024-02-04T01:53:50Z

Hi Tetsuo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on kees/for-next/execve]
[also build test WARNING on linux/master tip/sched/core linus/master v6.8-rc2 next-20240202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Tetsuo-Handa/LSM-add-security_execve_abort-hook/20240203-185605
base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve
patch link: https://lore.kernel.org/r/2a901d27-dba5-4ff4-9e47-373c54965253%40I-love.SAKURA.ne.jp
patch subject: [PATCH v2 2/3] tomoyo: replace current->in_execve flag with security_execve_abort() hook
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240204/202402040956.6IuNw6B3-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240204/202402040956.6IuNw6B3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402040956.6IuNw6B3-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> security/tomoyo/tomoyo.c:30: warning: Excess function parameter 'bprm' description in 'tomoyo_execve_abort'

vim +30 security/tomoyo/tomoyo.c

ee18d64c1f6320 David Howells 2009-09-02 23
0f2a55d5bb2372 Tetsuo Handa 2011-07-14 24 /**
89cebc094231d4 Tetsuo Handa 2024-02-03 25 * tomoyo_execve_abort - Target for security_execve_abort().
0f2a55d5bb2372 Tetsuo Handa 2011-07-14 26 *
89cebc094231d4 Tetsuo Handa 2024-02-03 27 * @bprm: void
0f2a55d5bb2372 Tetsuo Handa 2011-07-14 28 */
89cebc094231d4 Tetsuo Handa 2024-02-03 29 static void tomoyo_execve_abort(void)
f7433243770c77 Kentaro Takeda 2009-02-05 @30 {
89cebc094231d4 Tetsuo Handa 2024-02-03 31 /* Restore old_domain_info saved by execve() request. */
8c6cb983cd52d7 Tetsuo Handa 2019-01-19 32 struct tomoyo_task *s = tomoyo_task(current);
43fc460907dc56 Casey Schaufler 2018-09-21 33
89cebc094231d4 Tetsuo Handa 2024-02-03 34 if (s->old_domain_info) {
8c6cb983cd52d7 Tetsuo Handa 2019-01-19 35 atomic_dec(&s->domain_info->users);
8c6cb983cd52d7 Tetsuo Handa 2019-01-19 36 s->domain_info = s->old_domain_info;
8c6cb983cd52d7 Tetsuo Handa 2019-01-19 37 s->old_domain_info = NULL;
f7433243770c77 Kentaro Takeda 2009-02-05 38 }
ec8e6a4e062e2e Tetsuo Handa 2010-02-11 39 }
ec8e6a4e062e2e Tetsuo Handa 2010-02-11 40

--
0-DAY CI Kernel Test Service