* [PATCH fstests] common/config: fix CANON_DEVS=yes when file does not exist
@ 2024-02-14 17:42 Luis Chamberlain
2024-02-15 3:54 ` David Disseldorp
0 siblings, 1 reply; 4+ messages in thread
From: Luis Chamberlain @ 2024-02-14 17:42 UTC (permalink / raw)
To: fstests; +Cc: linux-fsdevel, patches, Luis Chamberlain
CANON_DEVS=yes allows you to use symlinks for devices, so fstests
resolves them back to the real backind device. The iteration for
resolving the backind device works obviously if you have the file
present, but if one was not present there is a parsing error. Fix
this parsing error introduced by a0c36009103b8 ("fstests: add helper
to canonicalize devices used to enable persistent disks").
Fixes: a0c36009103b8 ("fstests: add helper to canonicalize devices used to enable persistent disks"
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
common/config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/config b/common/config
index a3b15b96f336..2a1434bb11b9 100644
--- a/common/config
+++ b/common/config
@@ -679,7 +679,7 @@ _canonicalize_devices()
if [ -L $i ]; then
NEW_SCRATCH_POOL="$NEW_SCRATCH_POOL $(readlink -e $i)"
else
- NEW_SCRATCH_POOL="$NEW_SCRATCH_POOL $i)"
+ NEW_SCRATCH_POOL="$NEW_SCRATCH_POOL $i"
fi
done
SCRATCH_DEV_POOL="$NEW_SCRATCH_POOL"
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH fstests] common/config: fix CANON_DEVS=yes when file does not exist
2024-02-14 17:42 [PATCH fstests] common/config: fix CANON_DEVS=yes when file does not exist Luis Chamberlain
@ 2024-02-15 3:54 ` David Disseldorp
2024-02-15 17:50 ` Luis Chamberlain
0 siblings, 1 reply; 4+ messages in thread
From: David Disseldorp @ 2024-02-15 3:54 UTC (permalink / raw)
To: Luis Chamberlain; +Cc: fstests, linux-fsdevel, patches
On Wed, 14 Feb 2024 09:42:08 -0800, Luis Chamberlain wrote:
> CANON_DEVS=yes allows you to use symlinks for devices, so fstests
> resolves them back to the real backind device. The iteration for
> resolving the backind device works obviously if you have the file
s/backind/backing
> present, but if one was not present there is a parsing error. Fix
> this parsing error introduced by a0c36009103b8 ("fstests: add helper
> to canonicalize devices used to enable persistent disks").
>
> Fixes: a0c36009103b8 ("fstests: add helper to canonicalize devices used to enable persistent disks"
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: David Disseldorp <ddiss@suse.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH fstests] common/config: fix CANON_DEVS=yes when file does not exist
2024-02-15 3:54 ` David Disseldorp
@ 2024-02-15 17:50 ` Luis Chamberlain
2024-02-25 16:23 ` Zorro Lang
0 siblings, 1 reply; 4+ messages in thread
From: Luis Chamberlain @ 2024-02-15 17:50 UTC (permalink / raw)
To: David Disseldorp, Zorro Lang; +Cc: fstests, linux-fsdevel, patches
On Thu, Feb 15, 2024 at 02:54:22PM +1100, David Disseldorp wrote:
> On Wed, 14 Feb 2024 09:42:08 -0800, Luis Chamberlain wrote:
>
> > CANON_DEVS=yes allows you to use symlinks for devices, so fstests
> > resolves them back to the real backind device. The iteration for
> > resolving the backind device works obviously if you have the file
>
> s/backind/backing
Zorro, can you do the minor edit?
> > present, but if one was not present there is a parsing error. Fix
> > this parsing error introduced by a0c36009103b8 ("fstests: add helper
> > to canonicalize devices used to enable persistent disks").
> >
> > Fixes: a0c36009103b8 ("fstests: add helper to canonicalize devices used to enable persistent disks"
> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Reviewed-by: David Disseldorp <ddiss@suse.de>
Thanks!
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH fstests] common/config: fix CANON_DEVS=yes when file does not exist
2024-02-15 17:50 ` Luis Chamberlain
@ 2024-02-25 16:23 ` Zorro Lang
0 siblings, 0 replies; 4+ messages in thread
From: Zorro Lang @ 2024-02-25 16:23 UTC (permalink / raw)
To: Luis Chamberlain
Cc: David Disseldorp, Zorro Lang, fstests, linux-fsdevel, patches
On Thu, Feb 15, 2024 at 09:50:11AM -0800, Luis Chamberlain wrote:
> On Thu, Feb 15, 2024 at 02:54:22PM +1100, David Disseldorp wrote:
> > On Wed, 14 Feb 2024 09:42:08 -0800, Luis Chamberlain wrote:
> >
> > > CANON_DEVS=yes allows you to use symlinks for devices, so fstests
> > > resolves them back to the real backind device. The iteration for
> > > resolving the backind device works obviously if you have the file
> >
> > s/backind/backing
>
> Zorro, can you do the minor edit?
Sure, will do that.
>
> > > present, but if one was not present there is a parsing error. Fix
> > > this parsing error introduced by a0c36009103b8 ("fstests: add helper
> > > to canonicalize devices used to enable persistent disks").
> > >
> > > Fixes: a0c36009103b8 ("fstests: add helper to canonicalize devices used to enable persistent disks"
> > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> >
> > Reviewed-by: David Disseldorp <ddiss@suse.de>
>
> Thanks!
>
> Luis
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-25 16:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14 17:42 [PATCH fstests] common/config: fix CANON_DEVS=yes when file does not exist Luis Chamberlain
2024-02-15 3:54 ` David Disseldorp
2024-02-15 17:50 ` Luis Chamberlain
2024-02-25 16:23 ` Zorro Lang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).