From: Bart Van Assche <bvanassche@acm.org>
To: Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH v4 0/2] Fix libaio cancellation support
Date: Thu, 15 Feb 2024 12:47:37 -0800 [thread overview]
Message-ID: <20240215204739.2677806-1-bvanassche@acm.org> (raw)
Hi Christian,
This patch series fixes cancellation support in libaio as follows:
- Restore the code for completing cancelled I/O.
- Ignore requests to support cancellation for I/O not submitted by libaio.
Please consider this patch series for the next merge window.
Thanks,
Bart.
Changes between v3 and v4:
- Restored libaio cancellation support.
- Changed the approach to marking libaio requests with a flag in struct kiocb
instead of adding a new operation in struct file_operations.
Changes between v2 and v3:
- Removed libaio cancellation support instead of trying to fix it.
Changes between v1 and v2:
- Fixed a race between request completion and addition to the list of
active requests.
- Changed the return type of .cancel_kiocb() from int into void.
- Simplified the .cancel_kiocb() implementations.
- Introduced the ki_opcode member in struct aio_kiocb.
- aio_cancel_and_del() now checks .ki_opcode before accessing union members.
- Left out the include/include/mm changes.
Bart Van Assche (2):
fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio
fs/aio: Make io_cancel() generate completions again
fs/aio.c | 36 +++++++++++++++++++-----------------
include/linux/fs.h | 2 ++
2 files changed, 21 insertions(+), 17 deletions(-)
next reply other threads:[~2024-02-15 20:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 20:47 Bart Van Assche [this message]
2024-02-15 20:47 ` [PATCH v4 1/2] fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio Bart Van Assche
2024-02-21 14:26 ` Jens Axboe
2024-02-21 15:32 ` (subset) " Christian Brauner
2024-03-04 19:10 ` Eric Biggers
2024-03-04 19:43 ` Bart Van Assche
2024-03-04 20:21 ` Jens Axboe
2024-03-05 20:43 ` Bart Van Assche
2024-03-05 21:55 ` Jens Axboe
2024-03-04 20:09 ` Jens Axboe
2024-03-04 20:49 ` Eric Biggers
2024-03-04 20:53 ` Jens Axboe
2024-02-15 20:47 ` [PATCH v4 2/2] fs/aio: Make io_cancel() generate completions again Bart Van Assche
2024-02-16 7:13 ` Christoph Hellwig
2024-02-16 12:08 ` Christian Brauner
2024-02-16 17:11 ` Bart Van Assche
2024-02-27 8:55 ` (subset) " Christian Brauner
2024-02-21 9:26 ` [PATCH v4 0/2] Fix libaio cancellation support Christian Brauner
2024-02-21 17:39 ` Bart Van Assche
2024-02-26 20:50 ` Bart Van Assche
2024-02-27 8:55 ` Christian Brauner
2024-03-04 18:53 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215204739.2677806-1-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).