From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: brauner@kernel.org, amir73il@gmail.com, hu1.chen@intel.com
Cc: miklos@szeredi.hu, malini.bhandaru@intel.com,
tim.c.chen@intel.com, mikko.ylinen@intel.com,
lizhen.you@intel.com, linux-unionfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Vinicius Costa Gomes <vinicius.gomes@intel.com>
Subject: [RFC v3 2/5] cleanup: Fix discarded const warning when defining guard
Date: Thu, 15 Feb 2024 21:16:37 -0800 [thread overview]
Message-ID: <20240216051640.197378-3-vinicius.gomes@intel.com> (raw)
In-Reply-To: <20240216051640.197378-1-vinicius.gomes@intel.com>
When defining guards for const types the void* return implicitly
discards the const modifier. Be explicit about it.
Compiler warning (gcc 13.2.1):
./include/linux/cleanup.h:154:18: warning: return discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
154 | { return *_T; }
| ^~~
./include/linux/cred.h:193:1: note: in expansion of macro ‘DEFINE_GUARD’
193 | DEFINE_GUARD(cred, const struct cred *, _T = override_creds_light(_T),
| ^~~~~~~~~~~~
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
---
include/linux/cleanup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/cleanup.h b/include/linux/cleanup.h
index 085482ef46c8..c0347eb137a5 100644
--- a/include/linux/cleanup.h
+++ b/include/linux/cleanup.h
@@ -151,7 +151,7 @@ static inline class_##_name##_t class_##_name##ext##_constructor(_init_args) \
#define DEFINE_GUARD(_name, _type, _lock, _unlock) \
DEFINE_CLASS(_name, _type, if (_T) { _unlock; }, ({ _lock; _T; }), _type _T); \
static inline void * class_##_name##_lock_ptr(class_##_name##_t *_T) \
- { return *_T; }
+ { return (void *)*_T; }
#define DEFINE_GUARD_COND(_name, _ext, _condlock) \
EXTEND_CLASS(_name, _ext, \
--
2.43.1
next prev parent reply other threads:[~2024-02-16 5:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 5:16 [RFC v3 0/5] overlayfs: Optimize override/revert creds Vinicius Costa Gomes
2024-02-16 5:16 ` [RFC v3 1/5] cleanup: Fix discarded const warning when defining lock guard Vinicius Costa Gomes
2024-03-18 15:13 ` Christian Brauner
2024-03-18 15:57 ` Christian Brauner
2024-03-26 0:50 ` Vinicius Costa Gomes
2024-03-26 10:53 ` Christian Brauner
2024-03-26 13:19 ` Christian Brauner
2024-03-26 16:23 ` Vinicius Costa Gomes
2024-03-18 21:54 ` Vinicius Costa Gomes
2024-02-16 5:16 ` Vinicius Costa Gomes [this message]
2024-02-16 5:16 ` [RFC v3 3/5] cred: Add a light version of override/revert_creds() Vinicius Costa Gomes
2024-02-16 5:16 ` [RFC v3 4/5] fs: Optimize credentials reference count for backing file ops Vinicius Costa Gomes
2024-02-16 5:16 ` [RFC v3 5/5] overlayfs: Optimize credentials usage Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216051640.197378-3-vinicius.gomes@intel.com \
--to=vinicius.gomes@intel.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=hu1.chen@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=lizhen.you@intel.com \
--cc=malini.bhandaru@intel.com \
--cc=mikko.ylinen@intel.com \
--cc=miklos@szeredi.hu \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).