From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Avi Kivity <avi@scylladb.com>,
Sandeep Dhavale <dhavale@google.com>,
Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
stable@vger.kernel.org
Subject: Re: [PATCH v4 2/2] fs/aio: Make io_cancel() generate completions again
Date: Fri, 16 Feb 2024 08:13:25 +0100 [thread overview]
Message-ID: <20240216071325.GA10830@lst.de> (raw)
In-Reply-To: <20240215204739.2677806-3-bvanassche@acm.org>
On Thu, Feb 15, 2024 at 12:47:39PM -0800, Bart Van Assche wrote:
> The following patch accidentally removed the code for delivering
> completions for cancelled reads and writes to user space: "[PATCH 04/33]
> aio: remove retry-based AIO"
> (https://lore.kernel.org/all/1363883754-27966-5-git-send-email-koverstreet@google.com/)
Umm, that was more than 10 years ago. What code do you have that
is this old, and only noticed that it needs the completions now?
I'd much prefer your older patch to simply always fail the cancelations.
next prev parent reply other threads:[~2024-02-16 7:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 20:47 [PATCH v4 0/2] Fix libaio cancellation support Bart Van Assche
2024-02-15 20:47 ` [PATCH v4 1/2] fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio Bart Van Assche
2024-02-21 14:26 ` Jens Axboe
2024-02-21 15:32 ` (subset) " Christian Brauner
2024-03-04 19:10 ` Eric Biggers
2024-03-04 19:43 ` Bart Van Assche
2024-03-04 20:21 ` Jens Axboe
2024-03-05 20:43 ` Bart Van Assche
2024-03-05 21:55 ` Jens Axboe
2024-03-04 20:09 ` Jens Axboe
2024-03-04 20:49 ` Eric Biggers
2024-03-04 20:53 ` Jens Axboe
2024-02-15 20:47 ` [PATCH v4 2/2] fs/aio: Make io_cancel() generate completions again Bart Van Assche
2024-02-16 7:13 ` Christoph Hellwig [this message]
2024-02-16 12:08 ` Christian Brauner
2024-02-16 17:11 ` Bart Van Assche
2024-02-27 8:55 ` (subset) " Christian Brauner
2024-02-21 9:26 ` [PATCH v4 0/2] Fix libaio cancellation support Christian Brauner
2024-02-21 17:39 ` Bart Van Assche
2024-02-26 20:50 ` Bart Van Assche
2024-02-27 8:55 ` Christian Brauner
2024-03-04 18:53 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216071325.GA10830@lst.de \
--to=hch@lst.de \
--cc=avi@scylladb.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=bvanassche@acm.org \
--cc=dhavale@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).