From: Andrew Morton <akpm@linux-foundation.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: willy@infradead.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH] test_xarray: fix soft lockup for advanced-api tests
Date: Tue, 20 Feb 2024 11:00:50 -0800 [thread overview]
Message-ID: <20240220110050.210b1f2866d2c80716d021e8@linux-foundation.org> (raw)
In-Reply-To: <ZdTlL3UvlyrfpBlt@bombadil.infradead.org>
On Tue, 20 Feb 2024 09:45:19 -0800 Luis Chamberlain <mcgrof@kernel.org> wrote:
> > > --- a/lib/test_xarray.c
> > > +++ b/lib/test_xarray.c
> > > @@ -781,6 +781,7 @@ static noinline void *test_get_entry(struct xarray *xa, unsigned long index)
> > > {
> > > XA_STATE(xas, xa, index);
> > > void *p;
> > > + static unsigned int i = 0;
> >
> > I don't think this needs static storage.
>
> Actually it does, without it the schedule never happens and produces the
> soft lockup in the splat below.:
OK, I'll restore that.
prev parent reply other threads:[~2024-02-20 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 19:43 [PATCH] test_xarray: fix soft lockup for advanced-api tests Luis Chamberlain
2024-02-20 2:28 ` Andrew Morton
2024-02-20 17:45 ` Luis Chamberlain
2024-02-20 19:00 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220110050.210b1f2866d2c80716d021e8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=da.gomez@samsung.com \
--cc=gost.dev@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=oliver.sang@intel.com \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).