Re: [PATCH] iomap: Add processed for iomap_iter

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Feb 19, 2024 at 10:11:38AM +0800, Kassey Li wrote:
> processed: The number of bytes processed by the body in the
> most recent  iteration, or a negative errno. 0 causes the iteration to
> stop.
> 
> The processed is useful to check when the loop breaks.
> 
> Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>

Heh, sorry I didn't even see this one before it got merged, but:
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/iomap/trace.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/iomap/trace.h b/fs/iomap/trace.h
> index c16fd55f5595..ff87ac58b6b7 100644
> --- a/fs/iomap/trace.h
> +++ b/fs/iomap/trace.h
> @@ -165,6 +165,7 @@ TRACE_EVENT(iomap_iter,
>  		__field(u64, ino)
>  		__field(loff_t, pos)
>  		__field(u64, length)
> +		__field(s64, processed)
>  		__field(unsigned int, flags)
>  		__field(const void *, ops)
>  		__field(unsigned long, caller)
> @@ -174,15 +175,17 @@ TRACE_EVENT(iomap_iter,
>  		__entry->ino = iter->inode->i_ino;
>  		__entry->pos = iter->pos;
>  		__entry->length = iomap_length(iter);
> +		__entry->processed = iter->processed;
>  		__entry->flags = iter->flags;
>  		__entry->ops = ops;
>  		__entry->caller = caller;
>  	),
> -	TP_printk("dev %d:%d ino 0x%llx pos 0x%llx length 0x%llx flags %s (0x%x) ops %ps caller %pS",
> +	TP_printk("dev %d:%d ino 0x%llx pos 0x%llx length 0x%llx processed %lld flags %s (0x%x) ops %ps caller %pS",
>  		  MAJOR(__entry->dev), MINOR(__entry->dev),
>  		   __entry->ino,
>  		   __entry->pos,
>  		   __entry->length,
> +		   __entry->processed,
>  		   __print_flags(__entry->flags, "|", IOMAP_FLAGS_STRINGS),
>  		   __entry->flags,
>  		   __entry->ops,
> -- 
> 2.25.1
> 
>