[PATCH] iomap: Add processed for iomap_iter

[PATCH] iomap: Add processed for iomap_iter

[Kassey Li]

processed: The number of bytes processed by the body in the
most recent  iteration, or a negative errno. 0 causes the iteration to
stop.

The processed is useful to check when the loop breaks.

Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
---
 fs/iomap/trace.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/iomap/trace.h b/fs/iomap/trace.h
index c16fd55f5595..ff87ac58b6b7 100644
--- a/fs/iomap/trace.h
+++ b/fs/iomap/trace.h
@@ -165,6 +165,7 @@ TRACE_EVENT(iomap_iter,
 		__field(u64, ino)
 		__field(loff_t, pos)
 		__field(u64, length)
+		__field(s64, processed)
 		__field(unsigned int, flags)
 		__field(const void *, ops)
 		__field(unsigned long, caller)
@@ -174,15 +175,17 @@ TRACE_EVENT(iomap_iter,
 		__entry->ino = iter->inode->i_ino;
 		__entry->pos = iter->pos;
 		__entry->length = iomap_length(iter);
+		__entry->processed = iter->processed;
 		__entry->flags = iter->flags;
 		__entry->ops = ops;
 		__entry->caller = caller;
 	),
-	TP_printk("dev %d:%d ino 0x%llx pos 0x%llx length 0x%llx flags %s (0x%x) ops %ps caller %pS",
+	TP_printk("dev %d:%d ino 0x%llx pos 0x%llx length 0x%llx processed %lld flags %s (0x%x) ops %ps caller %pS",
 		  MAJOR(__entry->dev), MINOR(__entry->dev),
 		   __entry->ino,
 		   __entry->pos,
 		   __entry->length,
+		   __entry->processed,
 		   __print_flags(__entry->flags, "|", IOMAP_FLAGS_STRINGS),
 		   __entry->flags,
 		   __entry->ops,
-- 
2.25.1

Re: [PATCH] iomap: Add processed for iomap_iter

[Christian Brauner]

On Mon, 19 Feb 2024 10:11:38 +0800, Kassey Li wrote:
> processed: The number of bytes processed by the body in the
> most recent  iteration, or a negative errno. 0 causes the iteration to
> stop.
> 
> The processed is useful to check when the loop breaks.
> 
> 
> [...]

Applied to the vfs.iomap branch of the vfs/vfs.git tree.
Patches in the vfs.iomap branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.iomap

[1/1] iomap: Add processed for iomap_iter
      https://git.kernel.org/vfs/vfs/c/05cf9db6031d

Re: [PATCH] iomap: Add processed for iomap_iter

[Darrick J. Wong]

On Mon, Feb 19, 2024 at 10:11:38AM +0800, Kassey Li wrote:
> processed: The number of bytes processed by the body in the
> most recent  iteration, or a negative errno. 0 causes the iteration to
> stop.
> 
> The processed is useful to check when the loop breaks.
> 
> Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>

Heh, sorry I didn't even see this one before it got merged, but:
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/iomap/trace.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/iomap/trace.h b/fs/iomap/trace.h
> index c16fd55f5595..ff87ac58b6b7 100644
> --- a/fs/iomap/trace.h
> +++ b/fs/iomap/trace.h
> @@ -165,6 +165,7 @@ TRACE_EVENT(iomap_iter,
>  		__field(u64, ino)
>  		__field(loff_t, pos)
>  		__field(u64, length)
> +		__field(s64, processed)
>  		__field(unsigned int, flags)
>  		__field(const void *, ops)
>  		__field(unsigned long, caller)
> @@ -174,15 +175,17 @@ TRACE_EVENT(iomap_iter,
>  		__entry->ino = iter->inode->i_ino;
>  		__entry->pos = iter->pos;
>  		__entry->length = iomap_length(iter);
> +		__entry->processed = iter->processed;
>  		__entry->flags = iter->flags;
>  		__entry->ops = ops;
>  		__entry->caller = caller;
>  	),
> -	TP_printk("dev %d:%d ino 0x%llx pos 0x%llx length 0x%llx flags %s (0x%x) ops %ps caller %pS",
> +	TP_printk("dev %d:%d ino 0x%llx pos 0x%llx length 0x%llx processed %lld flags %s (0x%x) ops %ps caller %pS",
>  		  MAJOR(__entry->dev), MINOR(__entry->dev),
>  		   __entry->ino,
>  		   __entry->pos,
>  		   __entry->length,
> +		   __entry->processed,
>  		   __print_flags(__entry->flags, "|", IOMAP_FLAGS_STRINGS),
>  		   __entry->flags,
>  		   __entry->ops,
> -- 
> 2.25.1
> 
> 

Re: [PATCH] iomap: Add processed for iomap_iter

[Christian Brauner]

On Wed, Feb 21, 2024 at 08:31:05AM -0800, Darrick J. Wong wrote:
> On Mon, Feb 19, 2024 at 10:11:38AM +0800, Kassey Li wrote:
> > processed: The number of bytes processed by the body in the
> > most recent  iteration, or a negative errno. 0 causes the iteration to
> > stop.
> > 
> > The processed is useful to check when the loop breaks.
> > 
> > Signed-off-by: Kassey Li <quic_yingangl@quicinc.com>
> 
> Heh, sorry I didn't even see this one before it got merged, but:
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Yep, don't worry. I'm grabbing all your RVBs/ACKs later. :)