From: Colin Ian King <colin.i.king@gmail.com>
To: Wedson Almeida Filho <walmeida@microsoft.com>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] hfsplus: remove dev_err message "xattr exists yet"
Date: Wed, 6 Mar 2024 12:40:54 +0000 [thread overview]
Message-ID: <20240306124054.1785697-1-colin.i.king@gmail.com> (raw)
While exercising hfsplus with stress-ng with xattr tests the kernel
log was spammed with many "xattr exists yet" messages. The error
EOPNOTSUPP is returned, so the need to emit these error messages is
not necessary; removing them reduces kernel error spamming.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/hfsplus/xattr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
index 9c9ff6b8c6f7..57101524fff4 100644
--- a/fs/hfsplus/xattr.c
+++ b/fs/hfsplus/xattr.c
@@ -288,7 +288,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
if (!strcmp_xattr_finder_info(name)) {
if (flags & XATTR_CREATE) {
- pr_err("xattr exists yet\n");
err = -EOPNOTSUPP;
goto end_setxattr;
}
@@ -335,7 +334,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
if (hfsplus_attr_exists(inode, name)) {
if (flags & XATTR_CREATE) {
- pr_err("xattr exists yet\n");
err = -EOPNOTSUPP;
goto end_setxattr;
}
--
2.39.2
next reply other threads:[~2024-03-06 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 12:40 Colin Ian King [this message]
2024-03-06 15:00 ` [PATCH][next] hfsplus: remove dev_err message "xattr exists yet" Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306124054.1785697-1-colin.i.king@gmail.com \
--to=colin.i.king@gmail.com \
--cc=brauner@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=walmeida@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).