From: Zhang Yi <yi.zhang@huaweicloud.com>
To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, djwong@kernel.org,
hch@infradead.org, brauner@kernel.org, david@fromorbit.com,
tytso@mit.edu, jack@suse.cz, yi.zhang@huawei.com,
yi.zhang@huaweicloud.com, chengzhihao1@huawei.com,
yukuai3@huawei.com
Subject: [PATCH 0/4] xfs/iomap: fix non-atomic clone operation and don't update size when zeroing range post eof
Date: Mon, 11 Mar 2024 20:22:51 +0800 [thread overview]
Message-ID: <20240311122255.2637311-1-yi.zhang@huaweicloud.com> (raw)
From: Zhang Yi <yi.zhang@huawei.com>
This patch series fix a problem of exposing zeroed data on xfs since the
non-atomic clone operation. This problem was found while I was
developing ext4 buffered IO iomap conversion (ext4 is relying on this
fix [1]), the root cause of this problem and the discussion about the
solution please see [2]. After fix the problem, iomap_zero_range()
doesn't need to update i_size so that ext4 can use it to zero partial
block, e.g. truncate eof block [3].
[1] https://lore.kernel.org/linux-ext4/20240127015825.1608160-1-yi.zhang@huaweicloud.com/
[2] https://lore.kernel.org/linux-ext4/9b0040ef-3d9d-6246-4bdd-82b9a8f55fa2@huaweicloud.com/
[3] https://lore.kernel.org/linux-ext4/9c9f1831-a772-299b-072b-1c8116c3fb35@huaweicloud.com/
Thanks,
Yi.
Zhang Yi (4):
xfs: match lock mode in xfs_buffered_write_iomap_begin()
xfs: convert delayed extents to unwritten when zeroing post eof blocks
iomap: don't increase i_size if it's not a write operation
iomap: cleanup iomap_write_iter()
fs/iomap/buffered-io.c | 78 +++++++++++++++++++++---------------------
fs/xfs/xfs_iomap.c | 39 ++++++++++++++++++---
2 files changed, 73 insertions(+), 44 deletions(-)
--
2.39.2
next reply other threads:[~2024-03-11 12:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 12:22 Zhang Yi [this message]
2024-03-11 12:22 ` [PATCH 1/4] xfs: match lock mode in xfs_buffered_write_iomap_begin() Zhang Yi
2024-03-11 15:34 ` Darrick J. Wong
2024-03-12 8:18 ` Zhang Yi
2024-03-12 12:16 ` Christoph Hellwig
2024-03-11 12:22 ` [PATCH 2/4] xfs: convert delayed extents to unwritten when zeroing post eof blocks Zhang Yi
2024-03-11 15:37 ` Darrick J. Wong
2024-03-12 12:21 ` Christoph Hellwig
2024-03-12 12:44 ` Zhang Yi
2024-03-12 12:31 ` Zhang Yi
2024-03-12 16:21 ` Darrick J. Wong
2024-03-13 7:07 ` Zhang Yi
2024-03-13 13:25 ` Zhang Yi
2024-03-13 20:05 ` Darrick J. Wong
2024-03-11 12:22 ` [PATCH 3/4] iomap: don't increase i_size if it's not a write operation Zhang Yi
2024-03-11 15:48 ` Darrick J. Wong
2024-03-12 12:22 ` Christoph Hellwig
2024-03-12 12:59 ` Zhang Yi
2024-03-12 16:24 ` Darrick J. Wong
2024-03-13 7:09 ` Zhang Yi
2024-03-11 12:22 ` [PATCH 4/4] iomap: cleanup iomap_write_iter() Zhang Yi
2024-03-11 16:07 ` Darrick J. Wong
2024-03-12 12:24 ` Christoph Hellwig
2024-03-12 16:27 ` Darrick J. Wong
2024-03-13 9:23 ` Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311122255.2637311-1-yi.zhang@huaweicloud.com \
--to=yi.zhang@huaweicloud.com \
--cc=brauner@kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).