From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED913C060 for ; Wed, 20 Mar 2024 10:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710929615; cv=none; b=aOchbLqsNPWz6VfD/LImlrnc8s3Gqu+1kJIlAXxFPONTyYMhNeXcwrqL5m+AKDhJB9SD8C75kO0Ae8kk7JnT8/decoR0ih01zGrUsDLL3hE2LJgWb+bd72sqyk+OOai1aPtAU9G0i3Di6miJ9GMmS6FUI7W5SQEfvEN9rgwv3Eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710929615; c=relaxed/simple; bh=n2XzEygOK0nySHRN3D4rmjGC8c1yeBD1Db4Pw5gUFQE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U6dKYRiMgF+xVJduPSgitabxo3PtizoukocLMdHflfWDKC5FHGqR8ntbvBjqA+xGmHezKtPOdJ3xWmyEI9+tZ06QlFRF6PHy/v9TNt/tXM4Jmcf4sfNJTMDvqXcrIpJPmMF+XpgZY7qp73vkgvGlxmfaaydBglYspVfV7Tso47E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q+zVAn49; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q+zVAn49" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD551C433F1; Wed, 20 Mar 2024 10:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710929615; bh=n2XzEygOK0nySHRN3D4rmjGC8c1yeBD1Db4Pw5gUFQE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q+zVAn49cg9mP37W5VlNv4JjHBEcgWAtOEsWiBu9Eq6zulG/eStPXvlGvANUab5ud Xkm1ECbcAWBFOx1xhMp3sovYxZAK8JheY3yo5w3aMUpoqZp3Xy+aWkMgNiITdXbNgU SlvMOQ7rj0EUmxGqTXH+cd2Km/We6Jpiqcfgn54TUUJT9t76yEpruHVeo1Mi005aOn BghF2qLNt5tXwnD9HnjXJc8majnjDcaWECRk7b4JFJwtMFYAyg1bY+wqwObOACU5+8 3jvei3xJ8lRIq35evarPNAGtGStNCtkqJF2jMrdd+lun2OMr6JbP0Btee+Xt0nuHMZ B9MvN4HoPaFbw== Date: Wed, 20 Mar 2024 11:13:31 +0100 From: Christian Brauner To: Jan Kara Cc: Amir Goldstein , Jens Axboe , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 07/10] fsnotify: lazy attach fsnotify_sb_info state to sb Message-ID: <20240320-bachbett-gastdirigent-98fa18918ddd@brauner> References: <20240317184154.1200192-1-amir73il@gmail.com> <20240317184154.1200192-8-amir73il@gmail.com> <20240320-einblick-wimmeln-8fba6416c874@brauner> <20240320095134.np4fps7lwfollqwu@quack3> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240320095134.np4fps7lwfollqwu@quack3> On Wed, Mar 20, 2024 at 10:51:34AM +0100, Jan Kara wrote: > On Wed 20-03-24 11:37:57, Amir Goldstein wrote: > > On Wed, Mar 20, 2024 at 10:47 AM Christian Brauner wrote: > > > > > > On Sun, Mar 17, 2024 at 08:41:51PM +0200, Amir Goldstein wrote: > > > > Define a container struct fsnotify_sb_info to hold per-sb state, > > > > including the reference to sb marks connector. > > > > > > > > Allocate the fsnotify_sb_info state before attaching connector to any > > > > object on the sb and free it only when killing sb. > > > > > > > > This state is going to be used for storing per priority watched objects > > > > counters. > > > > > > > > Suggested-by: Jan Kara > > > > Signed-off-by: Amir Goldstein > > > > --- > > > > fs/notify/fsnotify.c | 16 +++++++++++++--- > > > > fs/notify/fsnotify.h | 9 ++++++++- > > > > fs/notify/mark.c | 32 +++++++++++++++++++++++++++++++- > > > > include/linux/fs.h | 8 ++++---- > > > > include/linux/fsnotify_backend.h | 17 +++++++++++++++++ > > > > 5 files changed, 73 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/fs/notify/fsnotify.c b/fs/notify/fsnotify.c > > > > index 503e7c75e777..fb3f36bc6ea9 100644 > > > > --- a/fs/notify/fsnotify.c > > > > +++ b/fs/notify/fsnotify.c > > > > @@ -89,11 +89,18 @@ static void fsnotify_unmount_inodes(struct super_block *sb) > > > > > > > > void fsnotify_sb_delete(struct super_block *sb) > > > > { > > > > + struct fsnotify_sb_info *sbinfo = fsnotify_sb_info(sb); > > > > + > > > > + /* Were any marks ever added to any object on this sb? */ > > > > + if (!sbinfo) > > > > + return; > > > > + > > > > fsnotify_unmount_inodes(sb); > > > > fsnotify_clear_marks_by_sb(sb); > > > > /* Wait for outstanding object references from connectors */ > > > > wait_var_event(fsnotify_sb_watched_objects(sb), > > > > !atomic_long_read(fsnotify_sb_watched_objects(sb))); > > > > + kfree(sbinfo); > > > > } > > > > > > > > /* > > > > @@ -489,6 +496,7 @@ int fsnotify(__u32 mask, const void *data, int data_type, struct inode *dir, > > > > { > > > > const struct path *path = fsnotify_data_path(data, data_type); > > > > struct super_block *sb = fsnotify_data_sb(data, data_type); > > > > + struct fsnotify_sb_info *sbinfo = fsnotify_sb_info(sb); > > > > struct fsnotify_iter_info iter_info = {}; > > > > struct mount *mnt = NULL; > > > > struct inode *inode2 = NULL; > > > > @@ -525,7 +533,7 @@ int fsnotify(__u32 mask, const void *data, int data_type, struct inode *dir, > > > > * SRCU because we have no references to any objects and do not > > > > * need SRCU to keep them "alive". > > > > */ > > > > - if (!sb->s_fsnotify_marks && > > > > + if ((!sbinfo || !sbinfo->sb_marks) && > > > > (!mnt || !mnt->mnt_fsnotify_marks) && > > > > (!inode || !inode->i_fsnotify_marks) && > > > > (!inode2 || !inode2->i_fsnotify_marks)) > > > > @@ -552,8 +560,10 @@ int fsnotify(__u32 mask, const void *data, int data_type, struct inode *dir, > > > > > > > > iter_info.srcu_idx = srcu_read_lock(&fsnotify_mark_srcu); > > > > > > > > - iter_info.marks[FSNOTIFY_ITER_TYPE_SB] = > > > > - fsnotify_first_mark(&sb->s_fsnotify_marks); > > > > + if (sbinfo) { > > > > + iter_info.marks[FSNOTIFY_ITER_TYPE_SB] = > > > > + fsnotify_first_mark(&sbinfo->sb_marks); > > > > + } > > > > if (mnt) { > > > > iter_info.marks[FSNOTIFY_ITER_TYPE_VFSMOUNT] = > > > > fsnotify_first_mark(&mnt->mnt_fsnotify_marks); > > > > diff --git a/fs/notify/fsnotify.h b/fs/notify/fsnotify.h > > > > index 8b73ad45cc71..378f9ec6d64b 100644 > > > > --- a/fs/notify/fsnotify.h > > > > +++ b/fs/notify/fsnotify.h > > > > @@ -53,6 +53,13 @@ static inline struct super_block *fsnotify_connector_sb( > > > > return fsnotify_object_sb(conn->obj, conn->type); > > > > } > > > > > > > > +static inline fsnotify_connp_t *fsnotify_sb_marks(struct super_block *sb) > > > > +{ > > > > + struct fsnotify_sb_info *sbinfo = fsnotify_sb_info(sb); > > > > + > > > > + return sbinfo ? &sbinfo->sb_marks : NULL; > > > > +} > > > > + > > > > /* destroy all events sitting in this groups notification queue */ > > > > extern void fsnotify_flush_notify(struct fsnotify_group *group); > > > > > > > > @@ -78,7 +85,7 @@ static inline void fsnotify_clear_marks_by_mount(struct vfsmount *mnt) > > > > /* run the list of all marks associated with sb and destroy them */ > > > > static inline void fsnotify_clear_marks_by_sb(struct super_block *sb) > > > > { > > > > - fsnotify_destroy_marks(&sb->s_fsnotify_marks); > > > > + fsnotify_destroy_marks(fsnotify_sb_marks(sb)); > > > > } > > > > > > > > /* > > > > diff --git a/fs/notify/mark.c b/fs/notify/mark.c > > > > index 0b703f9e6344..db053e0e218d 100644 > > > > --- a/fs/notify/mark.c > > > > +++ b/fs/notify/mark.c > > > > @@ -105,7 +105,7 @@ static fsnotify_connp_t *fsnotify_object_connp(void *obj, int obj_type) > > > > case FSNOTIFY_OBJ_TYPE_VFSMOUNT: > > > > return &real_mount(obj)->mnt_fsnotify_marks; > > > > case FSNOTIFY_OBJ_TYPE_SB: > > > > - return &((struct super_block *)obj)->s_fsnotify_marks; > > > > + return fsnotify_sb_marks(obj); > > > > default: > > > > return NULL; > > > > } > > > > @@ -568,6 +568,26 @@ int fsnotify_compare_groups(struct fsnotify_group *a, struct fsnotify_group *b) > > > > return -1; > > > > } > > > > > > > > +static int fsnotify_attach_info_to_sb(struct super_block *sb) > > > > +{ > > > > + struct fsnotify_sb_info *sbinfo; > > > > + > > > > + /* sb info is freed on fsnotify_sb_delete() */ > > > > + sbinfo = kzalloc(sizeof(*sbinfo), GFP_KERNEL); > > > > + if (!sbinfo) > > > > + return -ENOMEM; > > > > + > > > > + /* > > > > + * cmpxchg() provides the barrier so that callers of fsnotify_sb_info() > > > > + * will observe an initialized structure > > > > + */ > > > > + if (cmpxchg(&sb->s_fsnotify_info, NULL, sbinfo)) { > > > > + /* Someone else created sbinfo for us */ > > > > + kfree(sbinfo); > > > > + } > > > > > > Alternatively, you could consider using wait_var_event() to let > > > concurrent attachers wait for s_fsnotify_info to be initialized using a > > > sentinel value to indicate that the caller should wait. But not sure if > > > it's worth it. > > > > Not worth it IMO. Adding watches is an extremely rare event > > in the grand picture. > > Agreed. The cmpxchg() scheme has generally proven to be good enough in > similar situations and simple enough to understand... Thanks, sounds good to me.