From: Andrew Morton <akpm@linux-foundation.org>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: willy@infradead.org, jack@suse.cz, bfoster@redhat.com,
tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com,
dhowells@redhat.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Improve visibility of writeback
Date: Wed, 27 Mar 2024 10:40:10 -0700 [thread overview]
Message-ID: <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> (raw)
In-Reply-To: <20240327155751.3536-1-shikemeng@huaweicloud.com>
On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi <shikemeng@huaweicloud.com> wrote:
> This series tries to improve visilibity of writeback.
Well... why? Is anyone usefully using the existing instrumentation?
What is to be gained by expanding it further? What is the case for
adding this code?
I don't recall hearing of anyone using the existing debug
instrumentation so perhaps we should remove it!
Also, I hit a build error and a pile of warnings with an arm
allnoconfig build.
next prev parent reply other threads:[~2024-03-27 17:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 15:57 [PATCH v2 0/6] Improve visibility of writeback Kemeng Shi
2024-03-27 15:57 ` [PATCH v2 1/6] writeback: protect race between bdi release and bdi_debug_stats_show Kemeng Shi
2024-03-28 17:53 ` Brian Foster
2024-04-03 2:16 ` Kemeng Shi
2024-03-27 15:57 ` [PATCH v2 2/6] writeback: collect stats of all wb of bdi in bdi_debug_stats_show Kemeng Shi
2024-03-29 13:04 ` Brian Foster
2024-04-03 7:49 ` Kemeng Shi
2024-03-27 15:57 ` [PATCH v2 3/6] writeback: support retrieving per group debug writeback stats of bdi Kemeng Shi
2024-03-29 13:10 ` Brian Foster
2024-04-03 8:49 ` Kemeng Shi
2024-04-03 15:04 ` Brian Foster
2024-04-04 9:07 ` Jan Kara
2024-04-07 3:13 ` Kemeng Shi
2024-04-07 2:48 ` Kemeng Shi
2024-03-27 15:57 ` [PATCH v2 4/6] writeback: add wb_monitor.py script to monitor writeback info on bdi Kemeng Shi
2024-03-27 15:57 ` [PATCH v2 5/6] writeback: rename nr_reclaimable to nr_dirty in balance_dirty_pages Kemeng Shi
2024-03-27 15:57 ` [PATCH v2 6/6] writeback: define GDTC_INIT_NO_WB to null Kemeng Shi
2024-03-27 17:40 ` Andrew Morton [this message]
2024-03-28 1:59 ` [PATCH v2 0/6] Improve visibility of writeback Kemeng Shi
2024-03-28 8:23 ` Kemeng Shi
2024-03-28 19:15 ` Kent Overstreet
2024-03-28 19:23 ` Andrew Morton
2024-03-28 19:36 ` Kent Overstreet
2024-03-28 19:24 ` Kent Overstreet
2024-03-28 19:31 ` Tejun Heo
2024-03-28 19:40 ` Kent Overstreet
2024-03-28 19:46 ` Tejun Heo
2024-03-28 19:55 ` Kent Overstreet
2024-03-28 20:13 ` Tejun Heo
2024-03-28 20:22 ` Kent Overstreet
2024-03-28 20:46 ` Tejun Heo
2024-03-28 20:53 ` Kent Overstreet
2024-04-03 16:27 ` Jan Kara
2024-04-03 18:44 ` Tejun Heo
2024-04-03 19:06 ` Kent Overstreet
2024-04-03 19:21 ` Tejun Heo
2024-04-03 22:24 ` Kent Overstreet
2024-04-03 6:56 ` Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bfoster@redhat.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=shikemeng@huaweicloud.com \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).