From: Al Viro <viro@zeniv.linux.org.uk>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Christian Brauner <brauner@kernel.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: Add FOP_HUGE_PAGES
Date: Mon, 8 Apr 2024 16:02:17 +0100 [thread overview]
Message-ID: <20240408150217.GN538574@ZenIV> (raw)
In-Reply-To: <20240407201122.3783877-1-willy@infradead.org>
On Sun, Apr 07, 2024 at 09:11:20PM +0100, Matthew Wilcox (Oracle) wrote:
> -static inline bool is_file_hugepages(struct file *file)
> +static inline bool is_file_hugepages(const struct file *file)
> {
> - if (file->f_op == &hugetlbfs_file_operations)
> - return true;
> -
> - return is_file_shm_hugepages(file);
> + return file->f_op->fop_flags & FOP_HUGE_PAGES;
> }
Extra cacheline to pull can be costly on a sufficiently hot path...
next prev parent reply other threads:[~2024-04-08 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 20:11 [PATCH] fs: Add FOP_HUGE_PAGES Matthew Wilcox (Oracle)
2024-04-08 15:02 ` Al Viro [this message]
2024-04-08 15:42 ` Matthew Wilcox
2024-04-09 8:55 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408150217.GN538574@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).