From: Christian Brauner <brauner@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Hillf Danton <hdanton@sina.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fsnotify: fix UAF from FS_ERROR event on a shutting down filesystem
Date: Wed, 17 Apr 2024 13:35:23 +0200 [thread overview]
Message-ID: <20240417-geist-badeunfall-97d357510c0b@brauner> (raw)
In-Reply-To: <20240416181452.567070-1-amir73il@gmail.com>
On Tue, Apr 16, 2024 at 09:14:52PM +0300, Amir Goldstein wrote:
> Protect against use after free when filesystem calls fsnotify_sb_error()
> during fs shutdown.
>
> Move freeing of sb->s_fsnotify_info to destroy_super_work(), because it
> may be accessed from fs shutdown context.
>
> Reported-by: syzbot+5e3f9b2a67b45f16d4e6@syzkaller.appspotmail.com
> Suggested-by: Jan Kara <jack@suse.cz>
> Link: https://lore.kernel.org/linux-fsdevel/20240416173211.4lnmgctyo4jn5fha@quack3/
> Fixes: 07a3b8d0bf72 ("fsnotify: lazy attach fsnotify_sb_info state to sb")
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
Reviewed-by: Christian Brauner <brauner@kernel.org>
prev parent reply other threads:[~2024-04-17 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 18:14 [PATCH] fsnotify: fix UAF from FS_ERROR event on a shutting down filesystem Amir Goldstein
2024-04-17 10:05 ` Jan Kara
2024-04-17 11:35 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417-geist-badeunfall-97d357510c0b@brauner \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).