linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: willy@infradead.org, akpm@linux-foundation.org, jack@suse.cz,
	tj@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 05/10] writeback: call domain_dirty_avail in balance_dirty_pages
Date: Mon, 29 Apr 2024 11:47:33 +0800	[thread overview]
Message-ID: <20240429034738.138609-6-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20240429034738.138609-1-shikemeng@huaweicloud.com>

Call domain_dirty_avail in balance_dirty_pages to remove repeated code.
This is also a preparation to factor out repeated code calculating
dirty limits in balance_dirty_pages.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 mm/page-writeback.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index a1d48e8387ed..c41db87f4e98 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1747,9 +1747,8 @@ static int balance_dirty_pages(struct bdi_writeback *wb,
 		unsigned long m_bg_thresh = 0;
 
 		nr_dirty = global_node_page_state(NR_FILE_DIRTY);
-		gdtc->avail = global_dirtyable_memory();
-		gdtc->dirty = nr_dirty + global_node_page_state(NR_WRITEBACK);
 
+		domain_dirty_avail(gdtc, false);
 		domain_dirty_limits(gdtc);
 
 		if (unlikely(strictlimit)) {
@@ -1765,17 +1764,11 @@ static int balance_dirty_pages(struct bdi_writeback *wb,
 		}
 
 		if (mdtc) {
-			unsigned long filepages, headroom, writeback;
-
 			/*
 			 * If @wb belongs to !root memcg, repeat the same
 			 * basic calculations for the memcg domain.
 			 */
-			mem_cgroup_wb_stats(wb, &filepages, &headroom,
-					    &mdtc->dirty, &writeback);
-			mdtc->dirty += writeback;
-			mdtc_calc_avail(mdtc, filepages, headroom);
-
+			domain_dirty_avail(mdtc, false);
 			domain_dirty_limits(mdtc);
 
 			if (unlikely(strictlimit)) {
-- 
2.30.0


  parent reply	other threads:[~2024-04-29  3:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  3:47 [PATCH 00/10] Add helper functions to remove repeated code and Kemeng Shi
2024-04-29  3:47 ` [PATCH 01/10] writeback: factor out wb_bg_dirty_limits to remove repeated code Kemeng Shi
2024-05-01 16:40   ` Tejun Heo
2024-04-29  3:47 ` [PATCH 02/10] writeback: add general function domain_dirty_avail to calculate dirty and avail of domain Kemeng Shi
2024-05-01 16:49   ` Tejun Heo
2024-05-06  1:32     ` Kemeng Shi
2024-04-29  3:47 ` [PATCH 03/10] writeback: factor out domain_over_bg_thresh to remove repeated code Kemeng Shi
2024-05-01 16:53   ` Tejun Heo
2024-04-29  3:47 ` [PATCH 04/10] writeback use [global/wb]_domain_dirty_avail helper in cgwb_calc_thresh Kemeng Shi
2024-05-01 16:56   ` Tejun Heo
2024-05-06  1:36     ` Kemeng Shi
2024-04-29  3:47 ` Kemeng Shi [this message]
2024-05-01 16:57   ` [PATCH 05/10] writeback: call domain_dirty_avail in balance_dirty_pages Tejun Heo
2024-05-06  1:36     ` Kemeng Shi
2024-04-29  3:47 ` [PATCH 06/10] writeback: Factor out code of freerun to remove repeated code Kemeng Shi
2024-05-01 17:15   ` Tejun Heo
2024-05-06  1:38     ` Kemeng Shi
2024-04-29  3:47 ` [PATCH 07/10] writeback: factor out wb_dirty_freerun to remove more repeated freerun code Kemeng Shi
2024-05-01 17:18   ` Tejun Heo
2024-05-06  1:53     ` Kemeng Shi
2024-04-29  3:47 ` [PATCH 08/10] writeback: factor out balance_domain_limits to remove repeated code Kemeng Shi
2024-05-01 17:21   ` Tejun Heo
2024-04-29  3:47 ` [PATCH 09/10] writeback: factor out wb_dirty_exceeded " Kemeng Shi
2024-04-30  7:24   ` Dan Carpenter
2024-05-06  2:15     ` Kemeng Shi
2024-05-01 17:28   ` Tejun Heo
2024-04-29  3:47 ` [PATCH 10/10] writeback: factor out balance_wb_limits " Kemeng Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240429034738.138609-6-shikemeng@huaweicloud.com \
    --to=shikemeng@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).