From: Al Viro <viro@zeniv.linux.org.uk>
To: Dawid Osuchowski <linux@osuchow.ski>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org, jack@suse.cz
Subject: Re: [PATCH v3] fs: Create anon_inode_getfile_fmode()
Date: Wed, 8 May 2024 02:48:55 +0100 [thread overview]
Message-ID: <20240508014855.GN2118490@ZenIV> (raw)
In-Reply-To: <20240426075854.4723-1-linux@osuchow.ski>
On Fri, Apr 26, 2024 at 09:58:54AM +0200, Dawid Osuchowski wrote:
> Creates an anon_inode_getfile_fmode() function that works similarly to
> anon_inode_getfile() with the addition of being able to set the fmode
> member.
One note (followup commit fodder, probably in series with conversions to
that interface):
> + * @f_mode: [in] fmode
> + * setup. Allows setting the fmode. Returns the newly created file* or an error
is ambiguous - with no further information it reads as if we passed the value
to store in ->f_mode, which is not what's going on.
Something along the lines of
'f_mode' argument allows to set additional bits, on top of the ones set by
anon_inode_getfile() (FMODE_{OPENED,READ,WRITE,LSEEK,CAN_READ,CAN_WRITE}).
The caller should not pass those in 'f_mode' - they will be set according to
'flags' and 'fops' in all cases.
prev parent reply other threads:[~2024-05-08 1:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 7:58 [PATCH v3] fs: Create anon_inode_getfile_fmode() Dawid Osuchowski
2024-04-26 16:05 ` Christian Brauner
2024-05-08 0:41 ` Al Viro
2024-05-08 0:46 ` Al Viro
2024-05-08 11:37 ` Christian Brauner
2024-05-08 1:48 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508014855.GN2118490@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux@osuchow.ski \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).