linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: "hch@infradead.org" <hch@infradead.org>
Cc: Trond Myklebust <trondmy@hammerspace.com>,
	 "jack@suse.cz" <jack@suse.cz>,
	"chuck.lever@oracle.com" <chuck.lever@oracle.com>,
	 "linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alex.aring@gmail.com" <alex.aring@gmail.com>,
	 "cyphar@cyphar.com" <cyphar@cyphar.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	 "jlayton@kernel.org" <jlayton@kernel.org>,
	"amir73il@gmail.com" <amir73il@gmail.com>,
	 "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH RFC v2] fhandle: expose u64 mount id to name_to_handle_at(2)
Date: Tue, 28 May 2024 09:12:33 +0200	[thread overview]
Message-ID: <20240528-fraglich-abmildern-cca211d1791c@brauner> (raw)
In-Reply-To: <ZlS0_DWzGk24GYZA@infradead.org>

On Mon, May 27, 2024 at 09:29:48AM -0700, hch@infradead.org wrote:
> On Mon, May 27, 2024 at 03:38:40PM +0000, Trond Myklebust wrote:
> > > It
> > > does not matter what mount you use to access it.
> > 
> > Sure. However if you are providing a path argument, then presumably you
> > need to know which file system (aka super_block) it eventually resolves
> > to.
> 
> Except that you can't, at least not without running into potential
> races.  The only way to fix a race vs unmount/remount is to include
> the fsid part in the kernel generated file handle.
> 
> > 
> > If your use case isn't NFS servers, then what use case are you
> > targeting, and how do you expect those applications to use this API?
> 
> The main user of the open by handle syscalls seems to be fanotify
> magic.

It's also used by userspace for uniquely identifying cgroups via handles
as cgroups and - even without open_by_handle_at() - to check whether a
file is still valid.

And again a 64bit mount is is a simple way to race-free go to whatever
superblock uuid you want. They cannot be recycled and are unique for the
lifetime of the system.

  reply	other threads:[~2024-05-28  7:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23 20:57 [PATCH RFC v2] fhandle: expose u64 mount id to name_to_handle_at(2) Aleksa Sarai
2024-05-24  4:58 ` Amir Goldstein
2024-05-26  9:25 ` Christoph Hellwig
2024-05-26 19:01   ` Aleksa Sarai
2024-05-27 11:47     ` Christoph Hellwig
2024-05-27 12:29       ` Christian Brauner
2024-05-27 13:17         ` Christian Brauner
2024-05-27 15:47           ` Trond Myklebust
2024-05-28  7:05             ` Christian Brauner
2024-05-27 16:18         ` Christoph Hellwig
2024-05-27 13:34       ` Jan Kara
2024-05-27 16:24         ` Christoph Hellwig
2024-05-28  8:20           ` Christian Brauner
2024-05-28  8:28             ` Christoph Hellwig
2024-05-28  9:17               ` Christian Brauner
2024-05-28 10:55                 ` Christoph Hellwig
2024-05-28 12:04                   ` Christian Brauner
2024-05-28 13:22                     ` Christoph Hellwig
2024-05-28 13:28                       ` Miklos Szeredi
2024-05-29  6:34                         ` Christoph Hellwig
2024-06-01  8:12                         ` Aleksa Sarai
2024-06-03 10:30                           ` Jan Kara
2024-06-04  5:22                           ` Christoph Hellwig
2024-05-29  7:40                       ` Christian Brauner
2024-05-31  8:14                         ` Christoph Hellwig
2024-05-31 10:28                           ` Christian Brauner
2024-05-26 22:32   ` Trond Myklebust
2024-05-27 11:49     ` hch
2024-05-27 15:38       ` Trond Myklebust
2024-05-27 16:29         ` hch
2024-05-28  7:12           ` Christian Brauner [this message]
2024-05-28  7:15             ` hch
2024-05-28 10:11           ` Jan Kara
2024-05-28 10:56             ` hch
2024-05-28 23:25               ` Dave Chinner
2024-05-29  6:24                 ` hch
2024-05-29  7:23                   ` Amir Goldstein
2024-05-27 12:22   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528-fraglich-abmildern-cca211d1791c@brauner \
    --to=brauner@kernel.org \
    --cc=alex.aring@gmail.com \
    --cc=amir73il@gmail.com \
    --cc=chuck.lever@oracle.com \
    --cc=cyphar@cyphar.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).