From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: Dave Chinner <david@fromorbit.com>
Cc: chandan.babu@oracle.com, akpm@linux-foundation.org,
brauner@kernel.org, willy@infradead.org, djwong@kernel.org,
linux-kernel@vger.kernel.org, hare@suse.de,
john.g.garry@oracle.com, gost.dev@samsung.com,
yang@os.amperecomputing.com, p.raghav@samsung.com,
cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de,
mcgrof@kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v6 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size
Date: Tue, 4 Jun 2024 09:43:31 +0000 [thread overview]
Message-ID: <20240604094331.gybm6la3xdunpcin@quentin> (raw)
In-Reply-To: <Zlz+upnpESvduk7L@dread.disaster.area>
> > static int __init iomap_init(void)
> > {
> > + zero_fs_block = alloc_pages(GFP_KERNEL | __GFP_ZERO, ZERO_FSB_ORDER);
> > + if (!zero_fs_block)
> > + return -ENOMEM;
> > +
> > return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE),
> > offsetof(struct iomap_ioend, io_bio),
> > BIOSET_NEED_BVECS);
>
> just create an iomap_dio_init() function in iomap/direct-io.c
> and call that from here. Then everything can be private to
> iomap/direct-io.c...
Sounds good :)
next prev parent reply other threads:[~2024-06-04 9:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 13:44 [PATCH v6 00/11] enable bs > ps in XFS Pankaj Raghav (Samsung)
2024-05-29 13:44 ` [PATCH v6 01/11] readahead: rework loop in page_cache_ra_unbounded() Pankaj Raghav (Samsung)
2024-05-29 13:45 ` [PATCH v6 02/11] fs: Allow fine-grained control of folio sizes Pankaj Raghav (Samsung)
2024-06-03 6:28 ` Hannes Reinecke
2024-05-29 13:45 ` [PATCH v6 03/11] filemap: allocate mapping_min_order folios in the page cache Pankaj Raghav (Samsung)
2024-06-03 12:18 ` Matthew Wilcox
2024-06-04 9:42 ` Pankaj Raghav (Samsung)
2024-05-29 13:45 ` [PATCH v6 04/11] readahead: allocate folios with mapping_min_order in readahead Pankaj Raghav (Samsung)
2024-05-29 13:45 ` [PATCH v6 05/11] mm: split a folio in minimum folio order chunks Pankaj Raghav (Samsung)
2024-06-03 6:34 ` Hannes Reinecke
2024-06-03 12:36 ` Matthew Wilcox
2024-06-04 10:29 ` Pankaj Raghav (Samsung)
2024-05-29 13:45 ` [PATCH v6 06/11] filemap: cap PTE range to be created to allowed zero fill in folio_map_range() Pankaj Raghav (Samsung)
2024-06-03 6:35 ` Hannes Reinecke
2024-05-29 13:45 ` [PATCH v6 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Pankaj Raghav (Samsung)
2024-06-02 23:22 ` Dave Chinner
2024-06-04 9:43 ` Pankaj Raghav (Samsung) [this message]
2024-06-03 6:39 ` Hannes Reinecke
2024-05-29 13:45 ` [PATCH v6 08/11] xfs: use kvmalloc for xattr buffers Pankaj Raghav (Samsung)
2024-05-29 13:45 ` [PATCH v6 09/11] xfs: expose block size in stat Pankaj Raghav (Samsung)
2024-05-29 13:45 ` [PATCH v6 10/11] xfs: make the calculation generic in xfs_sb_validate_fsb_count() Pankaj Raghav (Samsung)
2024-05-29 13:45 ` [PATCH v6 11/11] xfs: enable block size larger than page size support Pankaj Raghav (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604094331.gybm6la3xdunpcin@quentin \
--to=kernel@pankajraghav.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=cl@os.amperecomputing.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).