From: Mateusz Guzik <mjguzik@gmail.com>
To: brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-bcachefs@vger.kernel.org, kent.overstreet@linux.dev,
linux-xfs@vger.kernel.org, david@fromorbit.com,
Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH v2 1/4] xfs: preserve i_state around inode_init_always in xfs_reinit_inode
Date: Tue, 11 Jun 2024 14:06:23 +0200 [thread overview]
Message-ID: <20240611120626.513952-2-mjguzik@gmail.com> (raw)
In-Reply-To: <20240611120626.513952-1-mjguzik@gmail.com>
This is in preparation for the routine starting to zero the field.
De facto coded by Dave Chinner, see:
https://lore.kernel.org/linux-fsdevel/ZmgtaGglOL33Wkzr@dread.disaster.area/
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
fs/xfs/xfs_icache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index 0953163a2d84..d31a2c1ac00a 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -314,6 +314,7 @@ xfs_reinit_inode(
dev_t dev = inode->i_rdev;
kuid_t uid = inode->i_uid;
kgid_t gid = inode->i_gid;
+ unsigned long state = inode->i_state;
error = inode_init_always(mp->m_super, inode);
@@ -324,6 +325,7 @@ xfs_reinit_inode(
inode->i_rdev = dev;
inode->i_uid = uid;
inode->i_gid = gid;
+ inode->i_state = state;
mapping_set_large_folios(inode->i_mapping);
return error;
}
--
2.43.0
next prev parent reply other threads:[~2024-06-11 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 12:06 [PATCH v2 0/4] inode_init_always zeroing i_state Mateusz Guzik
2024-06-11 12:06 ` Mateusz Guzik [this message]
2024-06-11 12:06 ` [PATCH v2 2/4] vfs: partially sanitize i_state zeroing on inode creation Mateusz Guzik
2024-06-12 9:27 ` Jan Kara
2024-06-13 11:41 ` Christian Brauner
2024-06-11 12:06 ` [PATCH v2 3/4] xfs: remove now spurious i_state initialization in xfs_inode_alloc Mateusz Guzik
2024-06-11 12:06 ` [PATCH v2 4/4] bcachefs: remove now spurious i_state initialization Mateusz Guzik
2024-06-11 23:38 ` Kent Overstreet
2024-06-12 12:17 ` [PATCH v2 0/4] inode_init_always zeroing i_state Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611120626.513952-2-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).