linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
	fstests@vger.kernel.org
Subject: Re: Flaky test: generic:269 (EBUSY on umount)
Date: Thu, 13 Jun 2024 22:56:39 +0100	[thread overview]
Message-ID: <20240613215639.GE1906022@mit.edu> (raw)
In-Reply-To: <20240612194136.GA2764780@frogsfrogsfrogs>

On Wed, Jun 12, 2024 at 12:41:36PM -0700, Darrick J. Wong wrote:
> 
> I don't see this problem; if you apply this to fstests to turn off
> io_uring:
> https://lore.kernel.org/fstests/169335095953.3534600.16325849760213190849.stgit@frogsfrogsfrogs/#r
> 
> do the problems go away?

Thanks for pointing out the mail thread; I had a vague memory that
this had been raised as a problem before.  Looking at the discussion
(from August 2023, so over 9 months ago), this is a bug that has been
acknowledged as an io_uring bug, but it still hasn't been fixed.

Using Zorro's sugestion of adding "-f uring_read=0 -f uring_write=0"
to the fsstress options makes the EBUSY umount failures go away.  I've
also created a new test which relaibly reproduces the "fsstress ;
umount" EBUSY bug (as opposed to the existing test failures which only
fail 1-10% of the time).  So with that I can with a clean conscience
suggest that we omit io_uring calls from those tests using fsstress to
thest some non-io_uring related bug if they run into the umount EBUSY
bug, since there is now a new bug which reliably shows off the
problem....

						- Ted

  reply	other threads:[~2024-06-13 21:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 16:29 Flaky test: generic:269 (EBUSY on umount) Theodore Ts'o
2024-06-12 19:41 ` Darrick J. Wong
2024-06-13 21:56   ` Theodore Ts'o [this message]
2024-06-13 22:18     ` [PATCH 1/2] generic/269, generic/475: disable io_uring to prevent umount EBUSY flakes Theodore Ts'o
2024-06-13 22:18       ` [PATCH 2/2] generic: new test which tests for an io_uring bug that causes umounts to fail Theodore Ts'o
2024-06-14  4:16     ` Flaky test: generic:269 (EBUSY on umount) Darrick J. Wong
2024-06-14 18:27       ` Theodore Ts'o
2024-06-14 20:44         ` Darrick J. Wong
2024-07-12  2:30           ` Theodore Ts'o
2024-08-23  1:16             ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240613215639.GE1906022@mit.edu \
    --to=tytso@mit.edu \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).