From: "Darrick J. Wong" <djwong@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
fstests@vger.kernel.org
Subject: Re: Flaky test: generic:269 (EBUSY on umount)
Date: Fri, 14 Jun 2024 13:44:30 -0700 [thread overview]
Message-ID: <20240614204430.GD6147@frogsfrogsfrogs> (raw)
In-Reply-To: <20240614182759.GF1906022@mit.edu>
On Fri, Jun 14, 2024 at 07:27:59PM +0100, Theodore Ts'o wrote:
> On Thu, Jun 13, 2024 at 09:16:18PM -0700, Darrick J. Wong wrote:
> >
> > Amusingly enough, I still have that patch (and generic/1220) in my
> > fstests branch, and I haven't seen this problem happen on g/1220 in
> > quite a while.
>
> Remind me what your fstests git repo is again?
https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfstests-dev.git/log/?h=djwong-wtf
> The generic/750 test in my patch 2/2 that I sent out reproduces the
> problem super-reliably, so long as fsstress actually issues the
> io_uring reads and writes. So if you have your patch applied which
> suppresses io_uring from fstress by default, you might need to modify
> the patch series to force the io_uring, at which point it quite nicely
> demonstrates the fsstress ; umount problem. (It sometimes requires
> more rounds of fsstress ; umounts before it repro's on the xfs/4k, but
> it repro's really nicely on ext4/4k).
Hm, your g/750 test mounts and unmounts in a loop, which might be why
mine hasn't tripped yet. I'll try applying it and report back.
--D
>
> xfs/4k:
> generic/750 Failed 3s
> generic/750 Failed 1s
> generic/750 Failed 33s
> generic/750 Failed 1s
> generic/750 Pass 33s
> ext4/4k:
> generic/750 Failed 3s
> generic/750 Failed 2s
> generic/750 Failed 7s
> generic/750 Failed 2s
> generic/750 Failed 7s
>
> - Ted
>
next prev parent reply other threads:[~2024-06-14 20:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 16:29 Flaky test: generic:269 (EBUSY on umount) Theodore Ts'o
2024-06-12 19:41 ` Darrick J. Wong
2024-06-13 21:56 ` Theodore Ts'o
2024-06-13 22:18 ` [PATCH 1/2] generic/269, generic/475: disable io_uring to prevent umount EBUSY flakes Theodore Ts'o
2024-06-13 22:18 ` [PATCH 2/2] generic: new test which tests for an io_uring bug that causes umounts to fail Theodore Ts'o
2024-06-14 4:16 ` Flaky test: generic:269 (EBUSY on umount) Darrick J. Wong
2024-06-14 18:27 ` Theodore Ts'o
2024-06-14 20:44 ` Darrick J. Wong [this message]
2024-07-12 2:30 ` Theodore Ts'o
2024-08-23 1:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614204430.GD6147@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).